Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Oct 2015 23:45:21 +0000 (UTC)
From:      "Conrad E. Meyer" <cem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r289906 - head/sys/dev/ioat
Message-ID:  <201510242345.t9ONjL52011861@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cem
Date: Sat Oct 24 23:45:21 2015
New Revision: 289906
URL: https://svnweb.freebsd.org/changeset/base/289906

Log:
  ioat: When queueing operations, assert the submit lock
  
  Callers should have acquired this lock when they invoked ioat_acquire()
  before issuing operations.  Assert it is held.
  
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/sys/dev/ioat/ioat.c

Modified: head/sys/dev/ioat/ioat.c
==============================================================================
--- head/sys/dev/ioat/ioat.c	Sat Oct 24 23:45:10 2015	(r289905)
+++ head/sys/dev/ioat/ioat.c	Sat Oct 24 23:45:21 2015	(r289906)
@@ -641,6 +641,7 @@ ioat_null(bus_dmaengine_t dmaengine, bus
 		flags & ~DMA_ALL_FLAGS));
 
 	ioat = to_ioat_softc(dmaengine);
+	mtx_assert(&ioat->submit_lock, MA_OWNED);
 
 	if (ioat_reserve_space_and_lock(ioat, 1) != 0)
 		return (NULL);
@@ -681,6 +682,7 @@ ioat_copy(bus_dmaengine_t dmaengine, bus
 		flags & ~DMA_ALL_FLAGS));
 
 	ioat = to_ioat_softc(dmaengine);
+	mtx_assert(&ioat->submit_lock, MA_OWNED);
 
 	if (len > ioat->max_xfer_size) {
 		ioat_log_message(0, "%s: max_xfer_size = %d, requested = %d\n",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510242345.t9ONjL52011861>