Date: Fri, 22 Mar 2013 16:12:00 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Boris Samorodov <bsam@passap.ru>, ports-committers@freebsd.org Subject: Re: svn commit: r314859 - head/palm/jpilot Message-ID: <20130322151200.GA14206@ithaqua.etoilebsd.net> In-Reply-To: <20130322145344.GA16844@FreeBSD.org> References: <201303211827.r2LIRHrh078301@svn.freebsd.org> <514C6DEF.10201@passap.ru> <20130322145344.GA16844@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--azLHFNyN32YCQGCU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 22, 2013 at 02:53:44PM +0000, Alexey Dokuchaev wrote: > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote: > > 21.03.2013 22:27, Baptiste Daroussin =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > --- head/palm/jpilot/Makefile Thu Mar 21 18:25:04 2013 (r314858) > > > +++ head/palm/jpilot/Makefile Thu Mar 21 18:27:17 2013 (r314859) > > [...] > > > -# "?=3D" and "+=3D" are for including this Makefile from japanese/jp= ilot > >=20 > > Not particular to this commit, but rather a general question: > > what is our current policy on comments at the makefile headers? > > I mean non-standard comments (maintainer tips, etc.). Should > > they be deleted? >=20 > I would not delete them (in general case). In this particular case I ass= ume > they were deleted because they were stating quite obvious thing: certain > variables with +=3D/?=3D are clear indication of master/slave relationshi= p. >=20 > ./danfe Deleting was a mistake, I will readd them once I'm back on a box where I can commit on the ports tree. Meaning probably monday. Except if somone wants to do it now, he gets my approval. regards, Bapt --azLHFNyN32YCQGCU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlFMdMAACgkQ8kTtMUmk6EzcVACdFUimXZ+aKTDf1SouEgdATJmY 6I8AoKzRWiXceuYdxo+zveYLVkLv9AgF =Rvfw -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130322151200.GA14206>