Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Aug 2009 23:05:08 -0500 (CDT)
From:      Stephen Montgomery-Smith <stephen@missouri.edu>
To:        "Jason J. Hellenthal" <jasonh@DataIX.net>
Cc:        Stephen Montgomery-Smith <stephen@missouri.edu>, ports@freebsd.org, ajtiM <lumiwa@gmail.com>
Subject:   Re: ImageMagick 6.5.4.10
Message-ID:  <alpine.BSF.2.00.0908122301500.18098@cauchy.math.missouri.edu>
In-Reply-To: <20090812235715.fc28351d.jasonh@DataIX.net>
References:  <200908122011.20408.lumiwa@gmail.com> <20090812221059.4f437ed4.jasonh@DataIX.net> <alpine.BSF.2.00.0908122143230.18098@cauchy.math.missouri.edu> <20090812235715.fc28351d.jasonh@DataIX.net>

next in thread | previous in thread | raw e-mail | index | archive | help


On Wed, 12 Aug 2009, Jason J. Hellenthal wrote:

> On Wed, 12 Aug 2009 21:44:39 -0500 (CDT)
> Stephen Montgomery-Smith <stephen@missouri.edu> wrote:
>
>>
>>
>> On Wed, 12 Aug 2009, Jason J. Hellenthal wrote:
>>
>>> On Wed, 12 Aug 2009 20:11:20 -0500
>>> ajtiM <lumiwa@gmail.com> wrote:
>>>
>>>> Update to 6.5.4.10 on FreeBSD 7.2
>>>>
>>>> magick/.libs/libMagickCore.so: undefined reference to `carg'
>>>> *** Error code 1
>>
>> Try this patch:
>>
>> diff -u magick/fourier-orig.c magick/fourier.c
>> --- magick/fourier-orig.c       2009-08-13 02:39:18.000000000 +0000
>> +++ magick/fourier.c    2009-08-13 02:40:13.000000000 +0000
>> @@ -515,7 +515,7 @@
>>         for (x=0L; x < (long) fourier_info->center; x++)
>>         {
>>           magnitude[i]=cabs(fourier[i]);
>> -        phase[i]=carg(fourier[i]);
>> +        phase[i]=atan2(cimag(fourier[i]),creal(fourier[i]));
>>           i++;
>>         }
>>     else
>>
>
> I conclude this fixes the problem on 7.2-RELEASE-p3/i386 Non-SMP

I submitted the fix at ports/137712

The function carg seems to have been introduced in FreeBSD 8.  If you look 
inside /usr/src/lib/msun/src/s_carg.c (on a machine with FreeBSD 8) you 
will see that the replacement I provided provides EXACTLY the same 
functionality.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0908122301500.18098>