From owner-svn-ports-head@freebsd.org Fri Apr 13 19:34:17 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB499FA1BF7 for ; Fri, 13 Apr 2018 19:34:16 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7242374395 for ; Fri, 13 Apr 2018 19:34:16 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-io0-x236.google.com with SMTP id b20so11451307iof.5 for ; Fri, 13 Apr 2018 12:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=eB3WuLTxB8O93IXScDsCTOfA5AvmsyQyY+In+v7dGMk=; b=mYRW9n1J5pNkAEyWs6NgJz2qvUNvmS1n803ACmkB001VAwtn3bsBEdLuxNMPXIP05s H4vEVO/rZOPQFEnrOSmMsfTy6S6i/5A6WyDMmASI0UA2HGNHWc1vwMX5c2e1OTHdZnUf jF7NdQrl+akLhDmJ6nyJI4VVgQN7krrUGXctajCEz/qBtrsTZWu0UjzYnBMoqXl8pSKD 1UrxJ3kPLMy1DOI2bOngjkndxJG5l35vjkzayhwwIl/KO6wwxXZSXKMouYssEjjt6Wta YsJc1zKtxGAIjYwJlPkOlbddrBJlBU7gVAn2YVGH0d41bXO293RmpxoGnHbJ13fAFWBl OkSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=eB3WuLTxB8O93IXScDsCTOfA5AvmsyQyY+In+v7dGMk=; b=OI6i622zyz+iGiBus5GntbdqxUS3k+RBIZoc96fYUH368fl7ilHWAm9Z3svFjS7Rqf 9iTI70dY9tllyM4R/UPvk6EySige9/UsUPRMNjAhCw8CmODEsgR5GwhjTO7bpCWLe81g 5+0tYEV0q7a2thW1rQPUXFqommRjyowfE+LG8Bpv8kPDkoUEQEn0yHw5mSKe8MYbuA33 i/pftNuL7vf48mIwpDzLkaf/V2O1cUAQ1KluK5zbIHEkMsgegPsmdAi1Eo4340mQ/Bjx iZlGGr/BBHZUyVbVpUITIo4FKdGNJ6a8YgswcBMP5jrqTacCW1omRT6XBm1H26CP6VvE hpWg== X-Gm-Message-State: ALQs6tB9YDOONLu5MsrXTpIE885X9pTjhc4Hl2mSqhCu2gYabaa9hjuK Po4M3wA2Jvc/zJ+OfAx9SR15QQRNTK+mRndoNrk83YGAO0s= X-Google-Smtp-Source: AIpwx4+dwDcDYWQtf/vFUjE5A8luiZTZmv0nPQ5uoFy/cCWq2rUjuDiWi6c8l77B2+VF/tN4cnfD6qp6xtMkKFq+ros= X-Received: by 10.107.14.136 with SMTP id 130mr14186363ioo.170.1523648055592; Fri, 13 Apr 2018 12:34:15 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.2.57.13 with HTTP; Fri, 13 Apr 2018 12:33:35 -0700 (PDT) In-Reply-To: <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> From: Sunpoet Po-Chuan Hsieh Date: Sat, 14 Apr 2018 03:33:35 +0800 X-Google-Sender-Auth: cm8elS4qCceHVmNXO5aso41Lrrk Message-ID: Subject: Re: svn commit: r467193 - in head/www/gitlab: . files To: Matthias Fechner Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 19:34:17 -0000 On Fri, Apr 13, 2018 at 5:55 PM, Matthias Fechner wrote: > Am 13.04.2018 um 10:41 schrieb Sunpoet Po-Chuan Hsieh: > > > I think that default_value_for 3.0.4 update is a different case. > gitlab wats default_value_for ~> 3.0.0 and it fits the rule. > > I would like to keep less number of gems with multiple versions in the > ports tree. > It will sometimes make the dependency tree complex. > Therefore, I would not copy the old version unless it's necessary. > > In this case, the only change between default_value_for 3.0.5 and 3.1.0 > is Rails 5.2 support [1]. > I don't think it breaks gitlab. > Can you please confirm if it really breaks gitlab? > If so, I'll revert it as soon as possible. > > I spent already days to find out why gitlab does not work or better that > some features are not working. An it most of the cases it was the last > feature I tested that failed. > All these problems are related to the fact that the Gemfile that is > delivered by gitlab was patched to use a newer version. > And please believe me, that is not fun. > > This is the reason why I removed nearly all patches from the Gemfile. > I include only patches that are absolutely necessary to get the gitlab > port install-able with FreeBSD ports (e.g. sentry-raven, httparty, saniti= ze > and some more). > > To make tests for all features in Gitlab you will require many hours and > I'm not willing to do the work the gitlab team is doing already for us. > They provide us with clear instructions what version are tested and shoul= d > work. > To be 100% save we should use what is in the Gemfile.lock, but this would > really a major effort and I think to use what is in Gemfile defined is > relatively safe. > I remember only 2 cases where even the definition in the Gemfiles cause > gitlab to break. One was the upgrade of default_value_for from 3.0.3 to > 3.0.4. > > So please stop to modify the Gemfile that comes with gitlab. > Please create a new port rubygem-default_value_for30 which is copied from > version 3.0.5. > If you like you can also fix the dep in the gitlab port to point to this > rubygem-default_value_for30 or I do not have a problem to do it by myself= . > OK, I understand your point of view. You want to be 100% safe by keeping Gemfile unchanged. When I notice an update may not fit the version in Gemfile, - If the version requirement can be relaxed, I patch the Gemfile. (I still think default_value_for 3.1.0 which only adds Rails 5.2 support is acceptable.) - otherwise, I'll svn keep a copy of the old version and update RUN_DEPENDS . That'll be fine if you want me to choose the second one unconditionally. I'll add rubygem-default_value_for30 and revert previous change of Gemfile. Regards, sunpoet > If ports are not required by gitlab anymore, I will mark them as expired > to clean up obsolete ports. > > Thanks a lot Sunpoet for you support i really appreciate. > > Gru=C3=9F > Matthias > > -- > > "Programming today is a race between software engineers striving to > build bigger and better idiot-proof programs, and the universe trying to > produce bigger and better idiots. So far, the universe is winning." -- > Rich Cook > >