From owner-cvs-src@FreeBSD.ORG  Tue Feb 17 07:30:54 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B144616A4CE; Tue, 17 Feb 2004 07:30:54 -0800 (PST)
Received: from srv01.sparkit.no (srv01.sparkit.no [193.69.116.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2811843D2D; Tue, 17 Feb 2004 07:30:54 -0800 (PST)
	(envelope-from eivind@FreeBSD.org)
Received: from ws ([193.69.114.88])
	by srv01.sparkit.no (8.12.10/8.12.10) with ESMTP id i1HFUniA077353;
	Tue, 17 Feb 2004 16:30:49 +0100 (CET)
	(envelope-from eivind@FreeBSD.org)
Received: from ws (localhost [127.0.0.1])
	by ws (8.12.9/8.12.10) with ESMTP id i1HFUHqB007278;
	Tue, 17 Feb 2004 15:30:17 GMT
	(envelope-from eivind@ws)
Received: (from eivind@localhost)
	by ws (8.12.9/8.12.10/Submit) id i1HFUGtf007268;
	Tue, 17 Feb 2004 15:30:16 GMT
	(envelope-from eivind)
Date: Tue, 17 Feb 2004 15:29:16 +0000
From: Eivind Eklund <eivind@FreeBSD.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Message-ID: <20040217152913.GE3525@FreeBSD.org>
References: <200401192127.i0JLRBL3041817@repoman.freebsd.org>
	<20040120175334.W3279@gamplex.bde.org> <20040213035557.M24031@gamplex.bde.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040213035557.M24031@gamplex.bde.org>
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Bruce Evans <bde@zeta.org.au>
Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386
	swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Feb 2004 15:30:54 -0000

On Fri, Feb 13, 2004 at 04:02:46AM +1100, Bruce Evans wrote:
> On Tue, 20 Jan 2004, Bruce Evans wrote:
> 
> > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote:
> >
> > > phk         2004/01/19 13:27:11 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/alpha/alpha      support.s
> > >     sys/i386/i386        swtch.s
> > >     sys/kern             kern_shutdown.c
> > >     sys/sys              systm.h
> > >   Log:
> > >   Add linenumber and source filename to panic(9) output.
> >
> > This was rejected in all reviews.  It gives less information than
> > grepping the sources, at some cost (grep at least gives correct line
> > numbers when the sources don't quite match the binary).
> >
> > Please back this out.
> 
> I'm still waiting for this to be backed out.
> 
> I just found yet another bug in it: it defeats simple regression checks.
> Suppose you make some cosmetic changes that add a line before a panic.
> This now changes the object file even when the file is compiled without
> -g.

This means file and line info HAS to be possible to disable, and should
(IMO) be off in LINT.

When I worked actively on the kernel, I regularly used the object file
comparison technique.  The technique is extremely useful to test various
cleanups, and even before the changed panic() messages a few log
messages that included __FILE__ and __LINE__ got in the way from time to
time.

Eivind.