From owner-cvs-src@FreeBSD.ORG Sat Oct 18 19:11:37 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AA33106568B; Sat, 18 Oct 2008 19:11:37 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id 02FFB8FC16; Sat, 18 Oct 2008 19:11:36 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id EEBAF2C2CB6; Sat, 18 Oct 2008 13:41:53 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id MoO3j4GAM+Zs; Sat, 18 Oct 2008 13:41:53 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id 189EA2C2B6E; Sat, 18 Oct 2008 13:41:53 -0500 (CDT) Message-ID: <48FA2DF0.10102@cs.rice.edu> Date: Sat, 18 Oct 2008 13:41:52 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.17 (X11/20080926) MIME-Version: 1.0 To: John Baldwin References: <200709151847.l8FIl2nC093179@repoman.freebsd.org> <200810171319.59992.jhb@freebsd.org> In-Reply-To: <200810171319.59992.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Alan Cox , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/amd64 uma_machdep.c src/sys/arm/arm vm_machdep.c src/sys/ia64/ia64 uma_machdep.c src/sys/powerpc/powerpc uma_machdep.c src/sys/sparc64/sparc64 vm_machdep.c src/sys/sun4v/sun4v vm_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Oct 2008 19:11:37 -0000 John Baldwin wrote: > On Saturday 15 September 2007 02:47:02 pm Alan Cox wrote: > >> alc 2007-09-15 18:47:02 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/amd64/amd64 uma_machdep.c >> sys/arm/arm vm_machdep.c >> sys/ia64/ia64 uma_machdep.c >> sys/powerpc/powerpc uma_machdep.c >> sys/sparc64/sparc64 vm_machdep.c >> sys/sun4v/sun4v vm_machdep.c >> Log: >> It has been observed on the mailing lists that the different categories >> of pages don't sum to anywhere near the total number of pages on amd64. >> This is for the most part because uma_small_alloc() pages have never been >> counted as wired pages, like their kmem_malloc() brethren. They should >> be. This changes fixes that. >> >> It is no longer necessary for the page queues lock to be held to free >> pages allocated by uma_small_alloc(). I removed the acquisition and >> release of the page queues lock from uma_small_free() on amd64 and ia64 >> weeks ago. This patch updates the other architectures that have >> uma_small_alloc() and uma_small_free(). >> >> Approved by: re (kensmith) >> > > I'd like to merge this to 6.x. However, I'm not sure if the same is true > about vm_page_free() not needing the vm_page_queues lock in 6.x, so figured > I'd ask you about that first. > > No, the page queue locking changes were never made to 6.x. However, the accounting fix (paragraph #1 above) is separable from the other change. Therefore, you could apply the accounting fix to 6.x with no trouble. In fact, the amd64 and ia64 parts of this commit were purely to apply the accounting fix because I had already removed the acquisition and release of the page queues lock from uma_small_{alloc,free} on those machines in an earlier revision. In effect, for 6.x you just need to replicate the amd64/ia64 version of this change across all six architectures. Alan