From owner-cvs-src Mon Feb 17 22:18:34 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3B1E937B401; Mon, 17 Feb 2003 22:18:32 -0800 (PST) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD3FD43F75; Mon, 17 Feb 2003 22:18:31 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id B82A32A89E; Mon, 17 Feb 2003 22:18:31 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include pci_cfgreg.h src/sys/i386/pci pci_bus.c pci_cfgreg.c src/sys/kern subr_witness.c In-Reply-To: <200302180336.h1I3aneM052083@repoman.freebsd.org> Date: Mon, 17 Feb 2003 22:18:31 -0800 From: Peter Wemm Message-Id: <20030218061831.B82A32A89E@canning.wemm.org> Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Peter Wemm wrote: > peter 2003/02/17 19:36:49 PST > > Modified files: > sys/i386/include pci_cfgreg.h > sys/i386/pci pci_bus.c pci_cfgreg.c > sys/kern subr_witness.c > Log: > Initiate de-orbit burn for USE_PCI_BIOS_FOR_READ_WRITE. This has been > #if'ed out for a while. Complete the deed and tidy up some other bits. > > We need to be able to call this stuff from outer edges of interrupt > handlers for devices that have the ISR bits in pci config space. Making > the bios code mpsafe was just too hairy. We had also stubbed it out some > time ago due to there simply being too much brokenness in too many systems. > This adds a leaf lock so that it is safe to use pci_read_config() and > pci_write_config() from interrupt handlers. We still will use pcibios > to do interrupt routing if there is no acpi.. [yes, I tested this] Incidently, did anybody know that it is utterly unsafe to use pci_read_config() or pci_write_config() in interrupt handlers on RELENG_4? And yes, lots of drivers do it a lot! :-( Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message