From owner-cvs-ports@FreeBSD.ORG  Sun Oct 10 07:23:29 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9A50616A4CE; Sun, 10 Oct 2004 07:23:29 +0000 (GMT)
Received: from mallaury.noc.nerim.net (smtp-100-sunday.noc.nerim.net
	[62.4.17.100])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 17FC043D46; Sun, 10 Oct 2004 07:23:29 +0000 (GMT)
	(envelope-from clement@FreeBSD.org)
Received: from satan.cultdeadsheep.org (charon.cultdeadsheep.org
	[80.65.226.72])	by mallaury.noc.nerim.net (Postfix) with SMTP
	id 764CA62D58; Sun, 10 Oct 2004 09:23:26 +0200 (CEST)
Date: Sun, 10 Oct 2004 09:23:21 +0200
From: Clement Laforet <clement@FreeBSD.org>
To: Clive Lin <clive@tongi.org>
Message-Id: <20041010092321.10b6395c.clement@FreeBSD.org>
In-Reply-To: <20041010023433.GA22907@CARTIER.mind.com>
References: <200410071759.i97HxIup039053@repoman.freebsd.org>
	<20041010023433.GA22907@CARTIER.mind.com>
Organization: FreeBSD Project
X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; i386-portbld-freebsd6.0)
Mime-Version: 1.0
Content-Type: multipart/signed; protocol="application/pgp-signature";
 micalg="pgp-sha1";
 boundary="Signature=_Sun__10_Oct_2004_09_23_21_+0200_LMdWyRAzI_EKrDyP"
cc: cvs-ports@FreeBSD.org
cc: kris@FreeBSD.org
cc: portmgr@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: Unable to build apache2 with threads (Re: cvs commit: ports/Mk
 bsd.port.mk)
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Oct 2004 07:23:29 -0000

--Signature=_Sun__10_Oct_2004_09_23_21_+0200_LMdWyRAzI_EKrDyP
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

On Sun, 10 Oct 2004 10:34:33 +0800
Clive Lin <clive@tongi.org> wrote:

Hi Clive,

> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.498&r2=1.499
> 
> this seems to stop apache2 build with threads. (WITH_MPM=worker)

I know ;-)
Actually, this change make apache2 port "violate" PTHREAD_LIBS.
I'll try to find a nice fix.
 
>     dirty hack as below, although I dont think it is a correct fix...
Thanks. The patch below minimizes impacts (if there's any), IMHO.
portmgr is Cc'd for approval.

clem

--- Makefile.orig       Sun Oct 10 09:16:35 2004
+++ Makefile    Sun Oct 10 09:16:52 2004
@@ -138,7 +138,7 @@
 PLIST_SUB+=    PORTS_APR=""
 .endif
 
-WITH_PTHREAD_LIBS?=    ${PTHREAD_LIBS:S/-l//}
+WITH_PTHREAD_LIBS?=    ${PTHREAD_LIBS:S/-l//:S/-//}
 WITH_PTHREAD_CFLAGS?=  ${PTHREAD_CFLAGS}
 
 .include "${APACHEDIR}/Makefile.doc"

--Signature=_Sun__10_Oct_2004_09_23_21_+0200_LMdWyRAzI_EKrDyP
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (FreeBSD)

iD8DBQFBaONtsRhfjwcjuh0RAj0vAJ407k0vmbgh4iWhtOGNFsBzlwPKRwCgxCap
4guBXI5CSof1OtOvnIuENj8=
=IaIW
-----END PGP SIGNATURE-----

--Signature=_Sun__10_Oct_2004_09_23_21_+0200_LMdWyRAzI_EKrDyP--