From owner-svn-ports-all@FreeBSD.ORG  Sat Mar 16 17:47:25 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 55268397; Sat, 16 Mar 2013 17:47:25 +0000 (UTC)
Date: Sat, 16 Mar 2013 17:47:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Koop Mast <kwm@FreeBSD.org>
Subject: Re: svn commit: r314380 - head/graphics/colord
Message-ID: <20130316174725.GA67587@FreeBSD.org>
References: <201303161736.r2GHas76043600@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201303161736.r2GHas76043600@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Mar 2013 17:47:25 -0000

On Sat, Mar 16, 2013 at 05:36:54PM +0000, Koop Mast wrote:
> New Revision: 314380
> URL: http://svnweb.freebsd.org/changeset/ports/314380
> 
> Log:
>   Prevert ! instead of empty() and fix a typo.

It seems you've fixed typo in original submission, not in the Makefile. :)
Could be confusing.

> @@ -57,7 +57,7 @@ post-patch:
>  		-e 's|-Wmissing-parameter-type||g' \
>  		-e 's|LIBS="-lusb-1.0|LIBS="-lusb|g' \
>  		${WRKSRC}/configure
> -.if empty(PORT_OPTIONS:MMANPAGES}
> +.if !${PORT_OPTIONS:MMANPAGES}

It's usually better to pad ! with a space after it, helps to stand out.

./danfe