From owner-svn-ports-all@FreeBSD.ORG Mon Apr 13 03:55:43 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 752229D4 for ; Mon, 13 Apr 2015 03:55:43 +0000 (UTC) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 113FA39C for ; Mon, 13 Apr 2015 03:55:42 +0000 (UTC) Received: (qmail 63607 invoked by uid 89); 13 Apr 2015 03:55:38 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 13 Apr 2015 03:55:38 -0000 Received: (qmail 63581 invoked by uid 89); 13 Apr 2015 03:55:21 -0000 Received: by simscan 1.3.1 ppid: 63572, pid: 63576, t: 0.0067s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 13 Apr 2015 03:55:21 -0000 Received: (qmail 24775 invoked by uid 89); 13 Apr 2015 03:55:21 -0000 Received: by simscan 1.4.0 ppid: 24766, pid: 24770, t: 1.0228s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 13 Apr 2015 03:55:20 -0000 From: Jan Beich To: John Marino Subject: Re: svn commit: r383843 - head/games/megaglest References: <201504120832.t3C8W2oh056956@svn.freebsd.org> <7fth-sdr1-wny@FreeBSD.org> <552AA964.4000306@marino.st> Date: Mon, 13 Apr 2015 05:55:08 +0200 Message-ID: <7ftg-el7n-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, John Marino , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 03:55:43 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable John Marino writes: >> John Marino writes: >>=20 >>> Megaglest cannot be built under c++11 standard from the latest clang. >>> It catches a narrowing error. The real solution is to fix the c++ >>> code (it wasn't the only problem, but the first to trigger an error o= ver >>> a warning). The c++11 standard is required for wx, so it can't be >>> unspecified. It turns out that gcc48 will not catch the error that c= lang >>> does so the temporary fix is to require gcc48 for all FreeBSD release= s. >>> This may work for gcc49 as well, but it's likely that gcc5 will also >>> catch the bug and break. >>=20 >> CXXFLAGS +=3D -Wno-c++11-narrowing ? GCC ignores unknown -Wno-foo. >>=20 >> Or maybe poke upstream if it has a fix: >>=20 >> #v+ >> Clang fix for tdefl_write_image_to_png_file_in_memory() from toffaletti https://code.google.com/p/miniz/issues/detail?id=3D6 >> --- source/shared_lib/sources/miniz/miniz.c (revision 56) >> +++ source/shared_lib/sources/miniz/miniz.c (revision 57) > > > IIUC - you're saying 1) what I did builds but doesn't work and 2) you've > got a patch that will let it build on clang. The part you've trimmed was an implicit request to _backout_ USE_GCC workarounds here and in r383839. megaglest fix is a by-product of trying to check how easy the homework was. > If I got that right, just go ahead and commit it. Are you flying solo > or with implicit permission these days? Low priority, sorry. My hardware is too slow to build-test properly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVKz4cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bGQ8H+gM8iSlhuJWHRhQz2Yt8AFHJ duy8EzuRFUH9QZjsfrEin0WIa2O3z2aOCeCdZM0XPOULrMqPdSKXFonzXRDMe0L6 7K1y4sr+uiSEu21HoCR+ivSmAUR4B+aYfQT7Np8+J26tBcoOKDGFQlDVi3XZfU7o m+hmO4KQUPiQLj0aWsXLeIrtDGX8zzkBvZuGsM/okCatu5AXromr+U2WRCybheIL hK+bfxykNhtcps0t4m/DcFtf7JcuzBmYx2rLdo7NCQw3II/x41Oc5ekGIL7uIDdQ cMU30X/9VmP8Q0jmleI1jWsfiw8KCmZrVDKSXUSx9AUSgjZL7XlixhyVxQ8wggs= =JEIz -----END PGP SIGNATURE----- --=-=-=--