Date: Tue, 1 Feb 2011 12:44:32 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Martin Matuska <mm@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r218169 - head/sys/cddl/compat/opensolaris/sys Message-ID: <20110201204432.GA15470@troutmask.apl.washington.edu> In-Reply-To: <201102011428.p11ESoQw074786@svn.freebsd.org> References: <201102011428.p11ESoQw074786@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 01, 2011 at 02:28:50PM +0000, Martin Matuska wrote: > Author: mm > Date: Tue Feb 1 14:28:50 2011 > New Revision: 218169 > URL: http://svn.freebsd.org/changeset/base/218169 > > Log: > For ZFS, change the type of clock_t to int64_t. > > The clock_t type in OpenSolaris is long (int64_t on amd64). > On FreeBSD clock_t is int32_t. The clock_t type is used in several places > in the ZFS code to store system uptime in milliseconds ("seconds * hz"). > > With hz=1000 we have a 32-bit integer overflow in 24 days, 20 hours, > 31 minutes and 23.648 seconds. This has a user reported negative impact > on l2arc_feed_thread() and may cause unexpected results from other functions > using clock_t. > > Reported by: Artem Belevich <fbsdlist@src.cx> on freebsd-fs@ > MFC after: 1 week > Please, revert! Tinderboxen are spamming my inbox. PS: Please test your patches before committing. Thanks. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110201204432.GA15470>