From owner-svn-src-head@FreeBSD.ORG  Tue Feb  1 20:44:32 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7ACA01065698;
	Tue,  1 Feb 2011 20:44:32 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.95.76.21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5B3968FC26;
	Tue,  1 Feb 2011 20:44:32 +0000 (UTC)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.4/8.14.4) with ESMTP id
	p11KiW0U015516; Tue, 1 Feb 2011 12:44:32 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.4/8.14.4/Submit) id
	p11KiWn0015515; Tue, 1 Feb 2011 12:44:32 -0800 (PST)
	(envelope-from sgk)
Date: Tue, 1 Feb 2011 12:44:32 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Martin Matuska <mm@freebsd.org>
Message-ID: <20110201204432.GA15470@troutmask.apl.washington.edu>
References: <201102011428.p11ESoQw074786@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201102011428.p11ESoQw074786@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r218169 - head/sys/cddl/compat/opensolaris/sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Feb 2011 20:44:32 -0000

On Tue, Feb 01, 2011 at 02:28:50PM +0000, Martin Matuska wrote:
> Author: mm
> Date: Tue Feb  1 14:28:50 2011
> New Revision: 218169
> URL: http://svn.freebsd.org/changeset/base/218169
> 
> Log:
>   For ZFS, change the type of clock_t to int64_t.
>   
>   The clock_t type in OpenSolaris is long (int64_t on amd64).
>   On FreeBSD clock_t is int32_t. The clock_t type is used in several places
>   in the ZFS code to store system uptime in milliseconds ("seconds * hz").
>   
>   With hz=1000 we have a 32-bit integer overflow in 24 days, 20 hours,
>   31 minutes and 23.648 seconds. This has a user reported negative impact
>   on l2arc_feed_thread() and may cause unexpected results from other functions
>   using clock_t.
>   
>   Reported by:	Artem Belevich <fbsdlist@src.cx> on freebsd-fs@
>   MFC after:	1 week
> 

Please, revert!

Tinderboxen are spamming my inbox.

PS: Please test your patches before committing.  Thanks.

-- 
Steve