Date: Mon, 16 Apr 2001 15:42:49 -0400 From: Barney Wolff <barney@databus.com> To: "E.B. Dreger" <eddy+public+spam@noc.everquick.net> Cc: Kris Kennaway <kris@obsecurity.org>, Wes Peters <wes@softweyr.com>, freebsd-security@FreeBSD.ORG, net@FreeBSD.ORG, provos@OpenBSD.org Subject: Re: non-random IP IDs Message-ID: <20010416154249.A49858@mx.databus.com> In-Reply-To: <Pine.LNX.4.20.0104161919390.26335-100000@www.everquick.net>; from eddy%2Bpublic%2Bspam@noc.everquick.net on Mon, Apr 16, 2001 at 07:24:07PM %2B0000 References: <20010416121019.D10023@xor.obsecurity.org> <Pine.LNX.4.20.0104161919390.26335-100000@www.everquick.net>
next in thread | previous in thread | raw e-mail | index | archive | help
If ip_randomid() is an asm rather than C code, I have sometimes seen problems with an asm func calling another asm func. That was long ago and far away, but is the only reason I can think of for that change. But whether the id is random or a counter, there is no reason to htons it, as long as it's treated consistently, with externals never compared with internals. Barney Wolff > > Date: Mon, 16 Apr 2001 12:10:19 -0700 > > From: Kris Kennaway <kris@obsecurity.org> > > > > I can't think of anything off the top of my head, but there was some > > reason why OpenBSD made this change: > > > > - ip_copy->ip_id = htons(ip_randomid()); > > + ip_copy->ip_id = ip_randomid(); > > + HTONS(ip_copy->ip_id); > > > > Presumably there was some reasoning there. Niels, can you shed any > > light? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010416154249.A49858>