Date: Tue, 28 Nov 2006 23:26:41 +0100 From: Henrik Brix Andersen <henrik@brixandersen.dk> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Florent Thoumie <flz@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs Message-ID: <20061128222641.GA73497@tirith.brixandersen.dk> In-Reply-To: <20061128220529.GA38107@rambler-co.ru> References: <200611282113.kASLD8vu090754@repoman.freebsd.org> <20061128220111.GA71168@tirith.brixandersen.dk> <20061128220529.GA38107@rambler-co.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 29, 2006 at 01:05:29AM +0300, Ruslan Ermilov wrote: > On Tue, Nov 28, 2006 at 11:01:11PM +0100, Henrik Brix Andersen wrote: > > On Tue, Nov 28, 2006 at 09:13:08PM +0000, Florent Thoumie wrote: > > > flz 2006-11-28 21:13:08 UTC > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs=20 > > > Log: > > > Add a quirk for devices recognized as usb keyboards not to be hooke= d by > > > ukbd(4). > > > =20 > > > PR: usb/105669 > > > Submitted by: Henrik Brix Andersen <henrik@brixandersen.dk> > > > MFC after: 1 week > >=20 > > Thank you for reviewing and committing this patch, much appreciated :) > >=20 > > Could you please bump __FreeBSD_version in sys/param.h as well as > > noted in the PR? This will allow checking for proper kernel support in > > my upcoming net-mgmt/wispy-tools port. > >=20 > Why can't you just check for the defined constant? To clarify: it is a run-time issue, not a compile-time issue. The application will compile fine regardless of the above patch, but without the above patch (and with ukbd/uhid loaded) the application will fail to attach to the device. How should I go about checking for the defined constant from the port? Regards, Brix --=20 Henrik Brix Andersen <henrik@brixandersen.dk> --KsGdsel6WgEHnImy Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: GnuPG signed iD8DBQFFbLehv+Q4flTiePgRAtuCAKC+LS5aBcO1UGoAM8UCu0xqvWHnEACeJjvW f9avgJZoYfPT1RhTOuBb/Cw= =RuUc -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061128222641.GA73497>