From owner-freebsd-ports@FreeBSD.ORG Wed Apr 16 14:59:06 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC68D106564A for ; Wed, 16 Apr 2008 14:59:06 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73]) by mx1.freebsd.org (Postfix) with ESMTP id 559898FC21 for ; Wed, 16 Apr 2008 14:59:06 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from [213.142.183.219] (helo=gahrtop.localhost) by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1Jm96H-0001sj-BP; Wed, 16 Apr 2008 16:59:05 +0200 Message-ID: <48061436.4080408@FreeBSD.org> Date: Wed, 16 Apr 2008 16:59:02 +0200 From: Pietro Cerutti Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080311) MIME-Version: 1.0 To: Ganael LAPLANCHE References: <48053F56.4090404@FreeBSD.org> <20080416064154.M28876@martymac.com> <4805BB13.1050007@FreeBSD.org> <20080416094711.M99470@martymac.com> <20080416134523.M15457@martymac.com> <48061303.6040001@FreeBSD.org> In-Reply-To: <48061303.6040001@FreeBSD.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=9571F78E; url=http://gahr.ch/pgp/ Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org X-Source: X-Source-Args: X-Source-Dir: Cc: ports@freebsd.org, Anatoly Borodin Subject: Re: CFT: devel/directfb update to 1.1.1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2008 14:59:06 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Pietro Cerutti wrote: | Ganael LAPLANCHE wrote: | | On Wed, 16 Apr 2008 16:01:43 +0300, Anatoly Borodin wrote | | | It produces the same error as previously reported : "No system | found!". Very | | strange, but applying those two patches allows the libs to be found | and mplayer | | to (nearly) start : | | | | --- lib/direct/interface.c.orig 2008-04-12 13:25:57.542006795 +0200 | | +++ lib/direct/interface.c 2008-04-12 13:26:27.732927708 +0200 | | @@ -164,7 +164,7 @@ | | /* | | * Iterate directory. | | */ | | - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) { | | + while (entry = readdir( dir )) { | | void *handle = NULL; | | char buf[4096]; | | | | --- lib/direct/modules.c.orig 2008-04-12 13:25:45.166038341 +0200 | | +++ lib/direct/modules.c 2008-04-12 13:27:56.054698492 +0200 | | @@ -158,7 +158,7 @@ | | return 0; | | } | | | | - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) { | | + while (entry = readdir( dir )) { | | void *handle; | | DirectModuleEntry *module; | | int entry_len = strlen(entry->d_name); | | Actually, there is a bug in those two functions. What about this one? | | --- lib/direct/modules.c.orig 2008-04-16 16:51:42.000000000 +0200 | +++ lib/direct/modules.c 2008-04-16 16:51:53.000000000 +0200 | @@ -158,7 +158,7 @@ | ~ return 0; | ~ } | | - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) { | + while (!readdir_r( dir, &tmp, &entry ) == 0 && entry) { | ~ void *handle; | ~ DirectModuleEntry *module; | ~ int entry_len = strlen(entry->d_name); | | --- lib/direct/interface.c.orig 2008-04-16 16:49:47.000000000 +0200 | +++ lib/direct/interface.c 2008-04-16 16:50:52.000000000 +0200 | @@ -164,7 +164,7 @@ | ~ /* | ~ * Iterate directory. | ~ */ | - while (readdir_r( dir, &tmp, &entry ) == 0 && entry) { | + while (!readdir_r( dir, &tmp, &entry ) && entry) { | ~ void *handle = NULL; | ~ char buf[4096]; | | | | Best regards, | Best, | | | Ganaël LAPLANCHE Sorry, I'm hallucinating... forget it.. - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEUEAREKAAYFAkgGFDYACgkQwMJqmJVx946ffgCXfxfnwMaD1nmE5Gu19dthTM2n 3QCeLTBhjhyP3ePpYgbkKnGrtRheEAM= =0+5s -----END PGP SIGNATURE-----