Date: Sun, 3 Mar 2019 13:56:32 -0700 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@freebsd.org> Cc: Garrett Cooper <yaneurabeya@gmail.com>, Steven Hartland <steven@multiplay.co.uk>, Alexey Dokuchaev <danfe@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344701 - head/sbin/camcontrol Message-ID: <CANCZdfrpUrNHrzaYfr2u5D-u8A4f5WBhRsoOhW9_%2BdeW8PuuUA@mail.gmail.com> In-Reply-To: <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> References: <201903011439.x21EdFlH055596@repo.freebsd.org> <20190302104909.GA25217@FreeBSD.org> <f65de4b9-c1a7-3b95-1507-d1ed2d120ed1@freebsd.org> <64CCD099-1916-4ACC-B1B6-3F22BDE55C7C@gmail.com> <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 3, 2019, 1:29 PM Ian Lepore <ian@freebsd.org> wrote: > On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > > On Mar 3, 2019, at 11:12, Steven Hartland <steven@multiplay.co.uk> > > > wrote: > > > > > > Not really much more to say that isn't explained by that and the > > > code. > > > > > > Sure I could have used a different sentence structure for the body > > > but it wouldn't add anything IMO, thoughts? > > > > Why the previous sector size was wrong isn=E2=80=99t clear from the > > commit message. Why switch from a sizeof to 0? > > Cheers! > > -Enji > > > > The commit message said it was "incorrect / unused". While a bit terse, > it does communicate that the old value was incorrect (by being there at > all) because the value is unused (so zero more clearly expresses that). > Correct. The standard also encourages that for future proofing the code. Though in this case this opcode is so old, there is almost zero chance it will change. Warner It's not completely a joke that most English-speaking software > engineers have English as a second language. :) > > -- Ian > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrpUrNHrzaYfr2u5D-u8A4f5WBhRsoOhW9_%2BdeW8PuuUA>