Date: Fri, 27 Sep 2013 20:36:43 +0200 From: Marcus von Appen <mva@FreeBSD.org> To: William Grzybowski <william88@gmail.com> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r328403 - head/Mk Message-ID: <20130927183643.GA35802@medusa.sysfault.org> In-Reply-To: <CAHtVNLPvWEO7bU1bUmc=gawB4HdytaTOosBR31V9JPBM_DYuyw@mail.gmail.com> References: <201309261827.r8QIR2Y8090911@svn.freebsd.org> <CAHtVNLPvWEO7bU1bUmc=gawB4HdytaTOosBR31V9JPBM_DYuyw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On, Thu Sep 26, 2013, William Grzybowski wrote:
[...]
> > + { ${ECHO_CMD} "#mtree"; ${CAT} ${MTREE_FILE}; } | ${TAR} tf - | \
> > + ${SED} '/^\.$$/d' > ${WRKDIR}/.localmtree
> > + ${ECHO_CMD} "${_RELSITELIBDIR}" >> ${WRKDIR}/.localmtree
> > + ${SED} 's|^${PREFIX}/||' ${_PYTHONPKGLIST} | ${SORT} >> ${TMPPLIST}
> > + ${SED} -e 's|^${PREFIX}/\(.*\)/\(.*\)|\1|' ${_PYTHONPKGLIST} | \
> > + while read line; do \
> > + ${GREP} -qw "^$${line}$$" ${WRKDIR}/.localmtree || { \
> > + [ -n "$${line}" ] && \
> > + ${ECHO_CMD} "@unexec rmdir $${line} 2>/dev/null || true"; \
> > + }; \
> > + done | ${SORT} | uniq | ${SORT} -r >> ${TMPPLIST}
>
> This logic iteration to find directories seems wrong.
> If I am not wrong and we have:
>
> dira/dirb/file1
> dira/dirc/file2
>
> And no files within dira/ it endes up removing dira/dirb/ and
> dira/dirc/, but not dira/.
Fixed, thanks for spotting this!
> Also, see this about enabling easy_install with AUTOPLIST and staging:
> http://people.freebsd.org/~wg/easyinstall-stage.txt
Working on it. I'm still a bit unsure about ports that do more complex
easy_install magic, so I'll try to get some of them properly tested
before committing your fix. Thanks!
Cheers
Marcus
--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iEYEARECAAYFAlJF0DoACgkQi68/ErJnpkeS0ACglaM3Nazs+4KBYEa7bV3HC+sN
gYgAoImfAVCfagrh7B5pd+r+5JM1ceYl
=6NuO
-----END PGP SIGNATURE-----
--y0ulUmNC+osPPQO6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130927183643.GA35802>