From owner-freebsd-bugs@freebsd.org Wed Apr 26 13:35:37 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 078A6D508EC for ; Wed, 26 Apr 2017 13:35:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D202FB1 for ; Wed, 26 Apr 2017 13:35:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3QDZaK0087448 for ; Wed, 26 Apr 2017 13:35:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 218889] top show CPU states header in batch mode Date: Wed, 26 Apr 2017 13:35:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: reed@reedmedia.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 13:35:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218889 Bug ID: 218889 Summary: top show CPU states header in batch mode Product: Base System Version: 11.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: reed@reedmedia.net (The component field here in bugzilla doesn't have "contrib" so I chose "bi= n".) I don't know history of why the dostates toggle is there to not show the CP= U: states "the first time". But this makes it so the batch view (like piped t= op to a file) excludes the CPU states and just has a blank line there. Here is a simple fix (but maybe fix comment). Or maybe just get rid of "dostates". Index: contrib/top/top.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/top/top.c (revision 317435) +++ contrib/top/top.c (working copy) @@ -637,7 +637,7 @@ system_info.procstates); /* display the cpu state percentage breakdown */ - if (dostates) /* but not the first time */ + if ((!interactive) || (dostates)) /* but not the first time */ { (*d_cpustates)(system_info.cpustates); } (I originally saw this problem with pfSense's System Activity page while authoring a book about it.) --=20 You are receiving this mail because: You are the assignee for the bug.=