From owner-freebsd-stable@FreeBSD.ORG  Wed Mar 30 17:07:24 2005
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 442E716A4CE; Wed, 30 Mar 2005 17:07:24 +0000 (GMT)
Received: from argent.heraldsnet.org (argent.heraldsnet.org [64.83.41.80])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C9B2143D49; Wed, 30 Mar 2005 17:07:23 +0000 (GMT)
	(envelope-from jtrigg@spamcop.net)
Received: from mail.scadian.net (localhost.scadian.net [IPv6:::1])
	by argent.heraldsnet.org (Postfix) with ESMTP id A2EA865D;
	Wed, 30 Mar 2005 12:07:22 -0500 (EST)
Received: from 128.222.32.10
        (SquirrelMail authenticated user blaise)
        by mail.scadian.net with HTTP;
        Wed, 30 Mar 2005 12:07:22 -0500 (EST)
Message-ID: <44027.128.222.32.10.1112202442.squirrel@mail.scadian.net>
In-Reply-To: <20050329234318.A3883@denninger.net>
References: <20050329200841.A772@denninger.net>
    <20050329233843.L328@sasami.jurai.net>
    <20050329230830.A3222@denninger.net>
    <20050329234318.A3883@denninger.net>
Date: Wed, 30 Mar 2005 12:07:22 -0500 (EST)
From: "Jim Trigg" <jtrigg@spamcop.net>
To: "Karl Denninger" <karl@denninger.net>
User-Agent: SquirrelMail/1.4.4
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Priority: 3 (Normal)
Importance: Normal
cc: freebsd-stable@freebsd.org
cc: "Matthew N. Dodd" <mdodd@freebsd.org>
Subject: 
 Re: DANGER WILL ROBINSON! SERIOUS problem with current 
     5.4-PRERELEASE
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Mar 2005 17:07:24 -0000

On Wed, March 30, 2005 12:43 am, Karl Denninger said:
> Here's the diff and some thoughts....

[snip, including first diff]

> 241,243c244,249
> <
> <       /* if reinit succeeded and retries still permit, reinject request
> */
> <       if (ata_reinit(ch) && request->retries-- > 0 &&
> request->device->param){
> ---
>>       /*
>>        * if reinit succeeds, retries still permit and device didn't
>>        * get removed by the reinit, reinject request
>>        */
>>       if (!ata_reinit(ch) && request->retries-- > 0
>>           && request->device->param){
[snip third diff]

> The second diff is really just a formatting and comment change.. you're
> certainly correct that the changes are small! :-)

No, it is not -- it reverses the sense of the first condition.  At first
glance that is what I would expect to be the core of the problem, but I
don't have appropriate hardware to test on.  (It also adds a third
condition, but that is presumably the intent of the change and should give
the desired results once the first condition is corrected.)

Jim
-- 
Jim Trigg, Lord High Everything Else  O-   /"\
Hostmaster, Huie Kin family website        \ /  ASCII RIBBON CAMPAIGN
Verger and System Administrator,            X    HELP CURE HTML MAIL
All Saints Church - Sharon Chapel          / \