From owner-svn-ports-all@freebsd.org Fri Feb 5 19:58:21 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F61BA77355; Fri, 5 Feb 2016 19:58:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 224651CF3; Fri, 5 Feb 2016 19:58:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 1B3D71F09; Fri, 5 Feb 2016 19:58:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C4BB21B0B7; Fri, 5 Feb 2016 19:58:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id tdS5JoemZPPW; Fri, 5 Feb 2016 19:58:16 +0000 (UTC) Subject: Re: svn commit: r408262 - head/editors/uemacs DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 14B661B0AF To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201602051859.u15IxnEx021230@repo.freebsd.org> <56B4FC78.6050005@FreeBSD.org> <56B4FD92.9080504@marino.st> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56B4FEE7.4040003@FreeBSD.org> Date: Fri, 5 Feb 2016 11:58:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56B4FD92.9080504@marino.st> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ILkne4LjVEVcnhIsTE2xrcOpHahPb03NR" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 19:58:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ILkne4LjVEVcnhIsTE2xrcOpHahPb03NR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/5/2016 11:52 AM, John Marino wrote: > On 2/5/2016 8:48 PM, Bryan Drewery wrote: >> On 2/5/2016 10:59 AM, John Marino wrote: >>> Author: marino >>> Date: Fri Feb 5 18:59:49 2016 >>> New Revision: 408262 >>> URL: https://svnweb.freebsd.org/changeset/ports/408262 >>> >>> Log: >>> editors/uemacs: document ncurses rqmt (USES+=3Dncurses), respect LD= FLAGS >>> =20 >>> Also link with ncurses, not termcap >>> =20 >>> approved by: infrastructure blanket >>> >>> Modified: >>> head/editors/uemacs/Makefile >>> >>> Modified: head/editors/uemacs/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/editors/uemacs/Makefile Fri Feb 5 18:57:54 2016 (r408261) >>> +++ head/editors/uemacs/Makefile Fri Feb 5 18:59:49 2016 (r408262) >>> @@ -13,10 +13,12 @@ COMMENT=3D Full screen editor >>> NO_CDROM=3D Resale allowed for media cost only >>> =20 >>> NO_WRKSUBDIR=3D yes >>> -USES=3D dos2unix zip >>> +USES=3D dos2unix ncurses zip >>> EXTRACT_BEFORE_ARGS=3D -Lq >>> =20 >>> post-patch: >>> @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c >>> + @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ >>> + ${WRKSRC}/freebsd/makefile >>> =20 >>> .include >>> >> >> lrwxr-xr-x 1 root wheel 13 Mar 27 2015 /usr/lib/libtermcap.so@ -> >> libncurses.so >> >> libtermcap is symlinked to libncurses. Why is it worth maintaining ext= ra >> code to link to ncurses directly? >> >=20 > Libtermcap does not exist in ports, it's not in devel/ncurses. > If one wants doesn't want to use base, the port can't be built. The > obvious solution is make everythink link with libncurses so both base > and ports options are supported. >=20 >=20 >=20 I assume this is from privatizing libraries on DragonFly. This is a great effort then as I hope FreeBSD does the same some day. Thanks! --=20 Regards, Bryan Drewery --ILkne4LjVEVcnhIsTE2xrcOpHahPb03NR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWtP7oAAoJEDXXcbtuRpfPkIQH/ioD38pJ4UOPbSBQws/mpG4J ItlrVNhkWqiIJTMmiGPBZmabsFUYj3Z9Rhso56i0sA/T517PRHa4yimtPvpuZKPq TJp6CDtlCW1TD246K6XkKTiqixqCxkrw581wFWKP3hMnW1N0vu3DMcV6ga/qhSUX K2yyTf+nK63fpFwbXTKcZLLQP3+xLeQCV/Ra12o73zOYCuMbPDyVD8QKkQ+iOlwb KNYUO52yH8YFaOirgXvBc9qsK4di/0sCc5xnxDgX6UI31wR2RtqsVnu5EuYY2Jod xKDOSxh1AJmDdjeLmwxXXY0rY+OVr2OW5N3fL3w8N9Ux9LM0lRSP9TJMrkt/fTM= =oZPf -----END PGP SIGNATURE----- --ILkne4LjVEVcnhIsTE2xrcOpHahPb03NR--