Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jan 2010 22:20:11 +0000 (GMT)
From:      Gavin Atkinson <gavin@FreeBSD.org>
To:        Gabor Kovesdan <gabor@FreeBSD.org>
Cc:        Doug Barton <dougb@FreeBSD.org>, cvs-doc@FreeBSD.org, cvs-all@FreeBSD.org, doc-committers@FreeBSD.org
Subject:   Re: cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml
Message-ID:  <alpine.BSF.2.00.1001042218400.41098@ury.york.ac.uk>
In-Reply-To: <4B42603E.6000503@FreeBSD.org>
References:  <201001042038.o04KcFo8028508@repoman.freebsd.org> <alpine.BSF.2.00.1001042109440.41098@ury.york.ac.uk> <4B425D7A.7030101@FreeBSD.org> <4B42603E.6000503@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 Jan 2010, Gabor Kovesdan wrote:

> El 2010. 01. 04. 22:28, Doug Barton escribi?:
> > Gavin Atkinson wrote:
> >    
> > > On Mon, 4 Jan 2010, Doug Barton wrote:
> > >      
> > > > dougb       2010-01-04 20:38:15 UTC
> > > > 
> > > >    Modified files:
> > > >      en_US.ISO8859-1/books/porters-handbook book.sgml
> > > >    Log:
> > > >    Actually having the $FreeBSD$ tag expanded in the example rc.d script
> > > >    did not end up looking as cool as I thought it would, so switch to an
> > > >    unexpanded example.
> > > > 
> > > >    Fix the text in the new paragraph to work better around the markup.
> > > >        
> > >      
> > > >        <para>  Unless there is a good reason to start the service
> > > > 	earlier all ports scripts should use
> > > > -	<programlisting>REQUIRE: LOGIN</programlisting>. If the service
> > > > +	<programlisting>REQUIRE: LOGIN</programlisting>  If the service
> > > > 	runs as a particular user (other than root) this is mandatory.
> > > >        
> > > This is now grammatically incorrect.  I actually think the original is
> > > better than any rewording I can come up with.
> > >      
> > Take a quick look at the page before it auto-updates. The old way the
> > period ends up all by itself in the text after the programlisting box,
> > so it looks like this:
> >    
> I would suggest the following:
> 
> <para>Unless there is a good reason to start the service
>   earlier all ports scripts should use the following:</para>
> 
> <programlisting>REQUIRE: LOGIN</programlisting>
> 
> <para>If the service ...</para>

I hadn't looked at the rendered output before now, I think Gabor's 
suggestion is probably the best answer.

Thanks,

Gavin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1001042218400.41098>