Date: Fri, 11 Jun 2010 22:10:59 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Mikolaj Golub <to.my.trociny@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: '#ifndef DIAGNOSTIC' in nfsclient code looks like a typo Message-ID: <20100611191059.GF13238@deviant.kiev.zoral.com.ua> In-Reply-To: <86mxv22ji7.fsf@zhuzha.ua1> References: <86mxv22ji7.fsf@zhuzha.ua1>
next in thread | previous in thread | raw e-mail | index | archive | help
--wtjvnLv0o8UUzur2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 11, 2010 at 09:03:44AM +0300, Mikolaj Golub wrote: > Hi: >=20 > '#ifndef DIAGNOSTIC' in sys/nfsclient/nfs_vnops.c and > sys/fs/nfsclient/nfs_clvnops.c looks like a typo and '#ifdef' should be u= sed > instead (see the attached patch). All the changes should be converted to the KASSERTs. There is no point in doing if (something) panic(); for diagnostic; use KASSERT(something, (panic message)); --wtjvnLv0o8UUzur2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwSikMACgkQC3+MBN1Mb4ht8wCg4Lo/kk++XQFke4I56+CCH46v O1cAnRHlBUAYSiDN3fKNYfxaT989cDOo =qNG7 -----END PGP SIGNATURE----- --wtjvnLv0o8UUzur2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100611191059.GF13238>