Date: Tue, 26 Apr 2011 15:54:56 -0400 From: John Baldwin <jhb@freebsd.org> To: Ryan Stone <rysto32@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started Message-ID: <201104261554.56218.jhb@freebsd.org> In-Reply-To: <BANLkTin0rAJUA_eScPDG_rVsVdnjTQWAJw@mail.gmail.com> References: <BANLkTinSyDaY-06N95n8c1NxOSdEnb5FkQ@mail.gmail.com> <201104251458.35718.jhb@freebsd.org> <BANLkTin0rAJUA_eScPDG_rVsVdnjTQWAJw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, April 26, 2011 3:46:06 pm Ryan Stone wrote: > On Mon, Apr 25, 2011 at 2:58 PM, John Baldwin <jhb@freebsd.org> wrote: > > > > Yes, I would perhaps tweak the comment to reflect the full if statement > > though. Maybe something like: > > > > /* > > * If SMP is started and the thread is pinned or otherwise limited to > > * a specific set of CPUs, queue the thread to a per-CPU run queue. > > * Otherwise, queue the thread to the global run queue. > > */ > > That looks fine, but I'm going to add a sentence explaining why the > smp_started condition is necessary: > > /* > * If SMP is started and the thread is pinned or otherwise limited to > * a specific set of CPUs, queue the thread to a per-CPU run queue. > * Otherwise, queue the thread to the global run queue. > * > * If SMP has not yet been started we must use the global run queue > * as per-CPU state may not be initialized yet and we may crash if we > * try to access the per-CPU run queues. > */ Sure, commit away. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104261554.56218.jhb>