Date: Sun, 29 May 2016 15:29:49 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416053 - head/Mk/Uses Message-ID: <20160529152949.GA88078@FreeBSD.org> In-Reply-To: <20160528200254.GI1036@fc.opsec.eu> References: <201605281719.u4SHJiAa008852@repo.freebsd.org> <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc> <20160528200254.GI1036@fc.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 28, 2016 at 10:02:55PM +0200, Kurt Jaeger wrote: > > [...] > > I should explain a bit more. > > > > This goes against the Right Way Of Doing Things(c)(r)(tm). > > > > To add a target to be run in the targets pipeline, you use _USES_xxx, you > > never, ever, piggyback on an existing target, especially if you're not > > using it. > > > > So, please, back this out. > > Done. I'm not sure *why* the kde folks requested this change > in the first place, so I'll ask them. In this case I'm even more puzzled: why commit a change that you don't fully understand? You should've asked them before committing, not after. Writing proper commit messages also helps: lack of "why" clause (or inability to come up with one) indicates that change is probably not committable yet. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160529152949.GA88078>