Date: Tue, 11 Jan 2000 23:19:45 +0800 From: Peter Wemm <peter@netplex.com.au> To: Dag-Erling Smorgrav <des@flood.ping.uio.no> Cc: "Cameron Grant" <gandalf@vilnya.demon.co.uk>, freebsd-current@FreeBSD.ORG Subject: Re: newpcm Message-ID: <20000111151945.9C6DD1CD1@overcee.netplex.com.au> In-Reply-To: Message from Dag-Erling Smorgrav <des@flood.ping.uio.no> of "11 Jan 2000 14:30:49 %2B0100." <xzpln5wrb06.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav wrote:
> "Cameron Grant" <gandalf@vilnya.demon.co.uk> writes:
> > would everyone who currently has an issue outstanding with newpcm please
> > report it to me in the next few days directly, please, so i can get an idea
> > of what needs work before release. i need as much detail as possible.
>
> My SB128 still doesn't attach:
>
> root@des ~# pciconf -l | grep none
> none0@pci0:10:0: class=0x040100 card=0x13711274 chip=0x13713274 rev=0x
06 hdr=0x00
> root@des ~# grep 1371 /var/run/dmesg.boot
> pci0: unknown card (vendor=0x3274, dev=0x1371) at 10.0 irq 5
Hmm.. different vendor id?
peter@overcee[11:16pm]~src/sys/dev/sound/pci-383> grep ES1371_PCI_ID *
es137x.c:#define ES1371_PCI_ID 0x13711274
es137x.c: } else if (pci_get_devid(dev) == ES1371_PCI_ID) {
es137x.c: if (pci_get_devid(dev) == ES1371_PCI_ID) {
Does the following hack work?
Index: es137x.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/sound/pci/es137x.c,v
retrieving revision 1.10
diff -u -r1.10 es137x.c
--- es137x.c 2000/01/05 02:03:55 1.10
+++ es137x.c 2000/01/11 15:18:52
@@ -70,6 +70,7 @@
/* PCI IDs of supported chips */
#define ES1370_PCI_ID 0x50001274
#define ES1371_PCI_ID 0x13711274
+#define ES1371_PCI_ID2 0x13713274
/* device private data */
struct es_info;
@@ -703,7 +704,8 @@
if (pci_get_devid(dev) == ES1370_PCI_ID) {
device_set_desc(dev, "AudioPCI ES1370");
return 0;
- } else if (pci_get_devid(dev) == ES1371_PCI_ID) {
+ } else if (pci_get_devid(dev) == ES1371_PCI_ID ||
+ pci_get_devid(dev) == ES1371_PCI_ID2) {
device_set_desc(dev, "AudioPCI ES1371");
return 0;
}
@@ -766,7 +768,8 @@
goto bad;
}
- if (pci_get_devid(dev) == ES1371_PCI_ID) {
+ if (pci_get_devid(dev) == ES1371_PCI_ID ||
+ pci_get_devid(dev) == ES1371_PCI_ID2) {
if(-1 == es1371_init(es, pci_get_revid(dev))) {
device_printf(dev, "unable to initialize the card\n");
goto bad;
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000111151945.9C6DD1CD1>