From owner-freebsd-ruby@freebsd.org Fri Aug 4 13:48:41 2017 Return-Path: Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38E50DABACE for ; Fri, 4 Aug 2017 13:48:41 +0000 (UTC) (envelope-from lifanov@FreeBSD.org) Received: from mail.lifanov.com (mail.lifanov.com [206.125.175.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1894069227; Fri, 4 Aug 2017 13:48:40 +0000 (UTC) (envelope-from lifanov@FreeBSD.org) Received: from lm0.local (rrcs-96-10-213-43.midsouth.biz.rr.com [96.10.213.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.lifanov.com (Postfix) with ESMTPSA id 1951C239AAC; Fri, 4 Aug 2017 09:48:40 -0400 (EDT) Subject: Re: [Stage-QA] Gemfile-Check - WIP To: freebsd-ruby@freebsd.org References: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org> From: Nikolai Lifanov Cc: Torsten Zuehlsdorff Message-ID: Date: Fri, 4 Aug 2017 09:48:38 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PbFiLwTKWmafCDv4qaksdSvdMQas7haBx" X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 13:48:41 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PbFiLwTKWmafCDv4qaksdSvdMQas7haBx Content-Type: multipart/mixed; boundary="lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9"; protected-headers="v1" From: Nikolai Lifanov To: freebsd-ruby@freebsd.org Cc: Torsten Zuehlsdorff Message-ID: Subject: Re: [Stage-QA] Gemfile-Check - WIP References: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org> In-Reply-To: <5a229e15-44b8-a941-7aa1-d6df667b744f@FreeBSD.org> --lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/4/17 8:51 AM, Torsten Zuehlsdorff wrote: > Aloha, >=20 > inspired by lifanov and his work in PR 220605 to add a check for > .gemspec of rubygems i tried myself with Gemfile. >=20 > Background is, that checking the actual Gemfile of non rubygem-* ports > is often very time-consuming. When building Gitlab, Redmine or others, > everything is fine. But when executing they fail - because the Gemfile > is not satisfied. >=20 > Its WIP and my first try for an stage-qa script, so every comment is > appreciated. It adds a stage-qa stage for every non rubygem- port. When= > executed i (intent) to scan for Gemfiles and checking every file with > bundle check. If bundle fails, the stage-qa fails. >=20 > It worked for simple test. If no Gemfile was present the test was > skipped. If it is, bundle is executed. When removing a needed dependenc= y > it is found. Its also found when the dependency is indirect (not in > Gemfile itself, but a dependency of an dependency listed there). >=20 > But it don't work for net-im/mikutter for example and i don't know why.= >=20 > So any feedback would be fine! :) >=20 > Greetings, > Torsten >=20 Hi! I think for something like this, a better initial approach is to make this stage-qa target non-fatal, so warnings instead of errors. At least initially it will cause less disruption and give porters an opportunity to fix the errors. I have two thoughts on it so far: $(find ${STAGEDIR} -name Gemfile) is pretty heavy to do on every port. Can we export something to QA_ENV from USE_RUBY and check for this instea= d? Is "bundle" guaranteed to be installed for ports that ship a Gemfile? Otherwise, it looks good and only has minor nits. Can we move this to Phabricator? This will make it easier to review and iterate on. Thank you! - Nikolai --lHMxEP62DKDDgOVFAia6c7UnIDGKlvOk9-- --PbFiLwTKWmafCDv4qaksdSvdMQas7haBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCAAyFiEE5oT6TcuaWvG5gtjzZ6sv56ecR0UFAlmEezcUHGxpZmFub3ZA ZnJlZWJzZC5vcmcACgkQZ6sv56ecR0VWuw/8DXvtR9bqhryqpqRvXcNOorK+sL+D F7uDETsKpVPBWsXuBPyOMBbXYuUyXky1N3/goWn8CdMwMyXCw9qDCOve7SqIFH/T IRdcPwjbV1tyKInJvmy47AlLofALeNiEJJillR5FFPDtX5ZmWfOFhXb2LfVBStZd pM5DYgj3KnDJw3ihqsbxCElD704aqtJ0+DUhRTO0+WVjoUS6YzR5/MfRh68BoZ9i D/Hk1s18o0KWyqyF4+qChvT4LnJWoQhTFJJHhbsKIoHnZhoSRFy5mE9TdNEXyN5t vS+EdEsdQgMwJgUaw3UzJXIlPMftVkZC8fgjD8AcrdpPYILWdpu5UO71xxdexJWZ yomfNTsrJr1OSAQ73HMIkY/JaizJuurG3UxXQ/IZJDnDIhcpblxWzs4hL6iZSGbf jBV0m6a/AgIEUAAv0KOceJ1qQePyUdNpowKip6wD0zz6s3O+c/oOnP7ERO68fr31 LReg4hh8cdirdExI0joNtr/xC9V1KtjlF6+pqvOPXeywoyCdVgvAX3St2yJgXC3q 5FbnsxHqyk4bbdhBraGU++4s0M0FXYgQum3Z6zNElAMb++JIpoaHv+cMLJ2PBHAW LookNS93il87qP8TkhiEC1CdQO2bL6Dvruh51PiXlMZSx1vsOQVnSOzoCtPdf7Uw Tp8YDQ+06pKaF/M= =hfWU -----END PGP SIGNATURE----- --PbFiLwTKWmafCDv4qaksdSvdMQas7haBx--