From owner-cvs-all@FreeBSD.ORG  Mon Sep 20 06:23:59 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9308416A4CF; Mon, 20 Sep 2004 06:23:59 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E17F743D55; Mon, 20 Sep 2004 06:23:58 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id i8K6NuxG044716;
	Mon, 20 Sep 2004 08:23:56 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Warner Losh <imp@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Mon, 20 Sep 2004 06:12:19 -0000."
             <200409200612.i8K6CJ12009866@repoman.freebsd.org> 
Date: Mon, 20 Sep 2004 08:23:56 +0200
Message-ID: <44715.1095661436@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fdc fdc_isa.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Sep 2004 06:23:59 -0000

In message <200409200612.i8K6CJ12009866@repoman.freebsd.org>, Warner Losh write
s:

>  It accesed FDSTS and FDDATA incorrectly via the second resource (which
>  wound up accessing FDOUT and the tape register at 0x3f3) and badly for
>  the CTL register (at location 0x3f4).  This is a minimal fix that just
>  'eats' the first one if it covers two locations and has an offset of
>  0.  This confusion lead the floppy driver to think there'd been a disk
>  change, which uncovered a deadlock in the floppy/geom code which lead
>  to a panic.

The "deadlock" is only there if the disk-change line goes from
active to inactive when it shouldn't.  To reset this pin it is necessary
to execute a step to the controller. 

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.