Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Mar 2007 13:46:48 +1000
From:      Sam Lawrance <boris@brooknet.com.au>
To:        Bartosz Fabianowski <freebsd@chillt.de>
Cc:        ports@freebsd.org
Subject:   Re: 170kB patch - how to handle?
Message-ID:  <C9BFC758-3203-4279-BBEC-9769FD1B3B6B@brooknet.com.au>
In-Reply-To: <460C73A4.1070901@chillt.de>
References:  <460C73A4.1070901@chillt.de>

next in thread | previous in thread | raw e-mail | index | archive | help

On 30/03/2007, at 12:19 PM, Bartosz Fabianowski wrote:

> Good day
>
> I would like to improve the audio/libvorbis port by optionally  
> patching in the aoTuV psychoacoustics, which are considered to be  
> superior to stock libvorbis. However, the patch file that does this  
> is ~170kB in size. I am wondering whether it is OK to put such a  
> large file directly into the ports tree or if it should be  
> downloaded as a distfile by each user. Is there any guideline on  
> which would be the correct method? I would hate for my suggestion  
> to be rejected by the port's maintainer due to me getting a  
> formality like this wrong.

I think it's better to keep something like this on ftp or http due to  
its size and the fact that most people probably won't turn on that  
option.  You can use PATCH_SITES and PATCHFILES in combination with a  
new port knob to automatically download and apply the patches.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C9BFC758-3203-4279-BBEC-9769FD1B3B6B>