From owner-freebsd-usb@FreeBSD.ORG  Thu May  5 21:33:28 2005
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 835C516A4CE
	for <usb@freebsd.org>; Thu,  5 May 2005 21:33:28 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2A50343D55
	for <usb@freebsd.org>; Thu,  5 May 2005 21:33:28 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.13.3/8.13.1) with ESMTP id j45LX2Zw094054;
	Thu, 5 May 2005 15:33:02 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 05 May 2005 15:33:02 -0600 (MDT)
Message-Id: <20050505.153302.71182158.imp@bsdimp.com>
To: julian@elischer.org
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <427A8EF3.70003@elischer.org>
References: <200505050618.j456IleO001353@sep.oldach.net>
	<427A887F.3020108@elischer.org>
	<427A8EF3.70003@elischer.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: usb@freebsd.org
cc: usbcrash@oldach.net
Subject: Re: recent USB MFCs cause panics
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2005 21:33:28 -0000

From: Julian Elischer <julian@elischer.org>
Subject: Re: recent USB MFCs cause panics
Date: Thu, 05 May 2005 14:24:03 -0700

> 
> 
> Julian Elischer wrote:
> 
> try:
> 
> in usb_port.h
> comment out line 425 (as below)
> 
> 422
>     423 #define config_detach(dev, flag) \
>     424         do { \
>     425                 /* device_detach(dev); */ \
>     426                 free(device_get_ivars(dev), M_USB); \
>     427                 device_delete_child(device_get_parent(dev), dev); \
>     428         } while (0);
>     429

Commenting it out is lame...  I fixed this in current in uhub.c as
well as here...  Since 'dev' is 0 here, I'm unsure that commenting it
out will fix the problem because the next line frees it....

Warner