From owner-freebsd-stable@freebsd.org Sat Mar 10 23:48:17 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB1C4F41660 for ; Sat, 10 Mar 2018 23:48:17 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 32BE86C516 for ; Sat, 10 Mar 2018 23:48:17 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 7cee881b-24bd-11e8-91c6-33ffc249f3e8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 7cee881b-24bd-11e8-91c6-33ffc249f3e8; Sat, 10 Mar 2018 23:48:11 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2ANm5Zs011960; Sat, 10 Mar 2018 16:48:05 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1520725685.84937.144.camel@freebsd.org> Subject: Re: zfs problems after rebuilding system [SOLVED] From: Ian Lepore To: Pete French , freebsd-stable@freebsd.org Date: Sat, 10 Mar 2018 16:48:05 -0700 In-Reply-To: <217437b9-9879-8919-966a-45cf5eb58d33@ingresso.co.uk> References: <21c64a2d-b9f9-24c8-88ec-ff1210891f60@zyxst.net> <65372449-53f1-8002-981a-e20f4a592e26@zyxst.net> <5CFC89E9-57BE-4CB7-9C55-0D3CCF1E8D3D@FreeBSD.org> <20180303234236.M3811@besplex.bde.org> <9b3cd942-347c-44a2-60d6-0b3c4a45552f@ingresso.co.uk> <1520723109.84937.136.camel@freebsd.org> <84146241-12d3-8333-0687-c2377838f175@ingresso.co.uk> <1520723722.84937.139.camel@freebsd.org> <217437b9-9879-8919-966a-45cf5eb58d33@ingresso.co.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 23:48:17 -0000 On Sat, 2018-03-10 at 23:42 +0000, Pete French wrote: > > > > It looks like r330745 applies fine to stable-11 without any changes, > > and there's plenty of value in testing that as well, if you're already > > set up for that world. > > > > Ive been running the patch from the PR in production since the original  > bug report and it works fine. I havent looked at r330745 yes, but can  > replace the PR patch with that and give it a whirl.... will take a look  > Monday at whats possible. > > -pete. > I based my fix heavily on that patch from the PR, but I rewrote it enough that I might've made any number of mistakes, so it needs fresh testing.  The main change I made was to make it a lot less noisy while waiting (it only mentions the wait once, unless bootverbose is set, in which case it's once per second).  I also removed the logic that limited the retries to nfs and zfs, because I think we can remove all the old code related to waiting that only worked for ufs and let this new retry be the way it waits for all filesystems.  But that's a bigger change we can do separately; I didn't want to hold up this fix any longer. -- Ian