Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2017 18:15:13 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r316904 - vendor/illumos/dist/lib/libzfs_core/common
Message-ID:  <201704141815.v3EIFD5J066331@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Fri Apr 14 18:15:13 2017
New Revision: 316904
URL: https://svnweb.freebsd.org/changeset/base/316904

Log:
  7729 libzfs_core`lzc_rollback() leaks result nvl
  
  illumos/illumos-gate@ac428481f96be89add7a1edf43ae47dd71038553
  https://github.com/illumos/illumos-gate/commit/ac428481f96be89add7a1edf43ae47dd71038553
  
  https://www.illumos.org/issues/7729
    libzfs_core`lzc_rollback() doesn't free the result nvl after lzc_ioctl() call.
  
  Reviewed by: Matthew Ahrens <mahrens@delphix.com>
  Reviewed by: Prakash Surya <prakash.surya@delphix.com>
  Approved by: Dan McDonald <danmcd@omniti.com>
  Author: Yuri Pankov <yuri.pankov@nexenta.com>

Modified:
  vendor/illumos/dist/lib/libzfs_core/common/libzfs_core.c

Modified: vendor/illumos/dist/lib/libzfs_core/common/libzfs_core.c
==============================================================================
--- vendor/illumos/dist/lib/libzfs_core/common/libzfs_core.c	Fri Apr 14 18:14:41 2017	(r316903)
+++ vendor/illumos/dist/lib/libzfs_core/common/libzfs_core.c	Fri Apr 14 18:15:13 2017	(r316904)
@@ -722,6 +722,8 @@ lzc_rollback(const char *fsname, char *s
 		const char *snapname = fnvlist_lookup_string(result, "target");
 		(void) strlcpy(snapnamebuf, snapname, snapnamelen);
 	}
+	nvlist_free(result);
+
 	return (err);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704141815.v3EIFD5J066331>