From owner-freebsd-current@FreeBSD.ORG Sun Nov 4 12:13:44 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F24693C; Sun, 4 Nov 2012 12:13:44 +0000 (UTC) (envelope-from hatanou@infolab.ne.jp) Received: from moon.infolab.ne.jp (unknown [IPv6:2001:3e0:90c::1]) by mx1.freebsd.org (Postfix) with ESMTP id DCEE48FC0A; Sun, 4 Nov 2012 12:13:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by moon.infolab.ne.jp (8.14.5/8.14.5) with ESMTP id qA4CDb0X035948; Sun, 4 Nov 2012 21:13:37 +0900 (JST) (envelope-from hatanou@infolab.ne.jp) Date: Sun, 04 Nov 2012 21:13:36 +0900 (JST) Message-Id: <20121104.211336.244701604.hatanou@infolab.ne.jp> To: freebsd-stable@freebsd.org Subject: Re: SU+J on 9.1-RC2 ISO From: HATANO Tomomi In-Reply-To: <5095B89F.4070705@freebsd.org> References: <20121103190930.GA23145@icarus.home.lan> <5095B89F.4070705@freebsd.org> Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Nov__4_21_13_36_2012_719)--" Content-Transfer-Encoding: 7bit Cc: jdc@koitsu.org, b.smeelen@ose.nl, fnwhitehorn@freebsd.org, freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Nov 2012 12:13:44 -0000 ----Next_Part(Sun_Nov__4_21_13_36_2012_719)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi all. The point is: There is completely no way to take a snapshot of SU+J partition unless modify one's kernel. Whether some issue still exist or not, how about enabling snapshoting SU+J partition through sysctl variable? Would you mind to see patch attached? 1. Taking a snapshot of SU+J partition is controlled through sysctl variable. 2. Default to disable. One who want to enable it should set the variable manually. 3. The default value in bsdinstall(8) may be left as is. -- HATANO Tomomi. ----Next_Part(Sun_Nov__4_21_13_36_2012_719)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="snapsuj.patch" --- src/sys/ufs/ffs/ffs_snapshot.c.orig 2012-11-04 11:01:58.000000000 +0900 +++ src/sys/ufs/ffs/ffs_snapshot.c 2012-11-04 11:13:32.000000000 +0900 @@ -182,8 +182,10 @@ */ int dopersistence = 0; -#ifdef DEBUG #include +int snapsuj = 0; +SYSCTL_INT(_debug, OID_AUTO, snapsuj, CTLFLAG_RW, &snapsuj, 0, ""); +#ifdef DEBUG SYSCTL_INT(_debug, OID_AUTO, dopersistence, CTLFLAG_RW, &dopersistence, 0, ""); static int snapdebug = 0; SYSCTL_INT(_debug, OID_AUTO, snapdebug, CTLFLAG_RW, &snapdebug, 0, ""); @@ -230,7 +232,7 @@ * At the moment, journaled soft updates cannot support * taking snapshots. */ - if (MOUNTEDSUJ(mp)) { + if (MOUNTEDSUJ(mp) && (snapsuj == 0)) { vfs_mount_error(mp, "%s: Snapshots are not yet supported when " "running with journaled soft updates", fs->fs_fsmnt); return (EOPNOTSUPP); ----Next_Part(Sun_Nov__4_21_13_36_2012_719)----