Date: Thu, 4 Feb 2010 10:13:16 +0100 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Roman Divacky <rdivacky@freebsd.org> Cc: Luigi Rizzo <luigi@freebsd.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r203481 - user/luigi/ipfw3-head/sys/netinet/ipfw Message-ID: <20100204091316.GC81601@onelab2.iet.unipi.it> In-Reply-To: <20100204075034.GA30179@freebsd.org> References: <201002040724.o147OD9l046782@svn.freebsd.org> <20100204075034.GA30179@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 04, 2010 at 08:50:34AM +0100, Roman Divacky wrote: > On Thu, Feb 04, 2010 at 07:24:13AM +0000, Luigi Rizzo wrote: > > Author: luigi > > Date: Thu Feb 4 07:24:13 2010 > > New Revision: 203481 > > URL: http://svn.freebsd.org/changeset/base/203481 > > > > Log: > > portability fix for compilers that do not have C99 initializers > > C99 in kernel is a must and has been for a long time... I dont think > that obfuscating obvious code to be able to support ancient compiler(s) > is worth it... unfortunately this code is shared among multiple platforms (including a Windows NDIS driver and the only way i know to do it is using MSVC), and keeping separate distributions is too expensive in terms of mainteinance. I tried for almost one year not to pollute the code in the tree with #ifdefs and intrusive portability tricks, but the only effect was to slow down development and fixes to the FreeBSD code. I'll try and see if i can find some other tricks to achieve the same result before the code is merged into HEAD. cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100204091316.GC81601>