From owner-svn-src-all@FreeBSD.ORG Wed Jul 22 08:06:47 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE8DA106564A; Wed, 22 Jul 2009 08:06:47 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from pin.if.uz.zgora.pl (pin.if.uz.zgora.pl [212.109.128.251]) by mx1.freebsd.org (Postfix) with ESMTP id 9D8D38FC15; Wed, 22 Jul 2009 08:06:47 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: by pin.if.uz.zgora.pl (Postfix, from userid 1001) id 3D1EF39BA2; Wed, 22 Jul 2009 10:08:45 +0200 (CEST) Date: Wed, 22 Jul 2009 10:08:45 +0200 From: Edward Tomasz Napierala To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <20090722080845.GA32501@pin.if.uz.zgora.pl> References: <200907201916.n6KJGhEl086253@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <200907201916.n6KJGhEl086253@svn.freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Subject: Re: svn commit: r195785 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 08:06:48 -0000 On 0720T1916, Edward Tomasz Napierala wrote: > Author: trasz > Date: Mon Jul 20 19:16:42 2009 > New Revision: 195785 > URL: http://svn.freebsd.org/changeset/base/195785 > > Log: > Fix permission handling for extended attributes in ZFS. Without > this change, ZFS uses SunOS Alternate Data Streams semantics - each > EA has its own permissions, which are set at EA creation time > and - unlike SunOS - invisible to the user and impossible to change. > From the user point of view, it's just broken: sometimes access > is granted when it shouldn't be, sometimes it's denied when > it shouldn't be. > > This patch makes it behave just like UFS, i.e. depend on current > file permissions. Also, it fixes returned error codes (ENOATTR > instead of ENOENT) and makes listextattr(2) return 0 instead > of EPERM where there is no EA directory (i.e. the file never had > any EA). > > Reviewed by: pjd (idea, not actual code) > Approved by: re (kib) Also: Reviewed by: kmacy -- If you cut off my head, what would I say? Me and my head, or me and my body?