Date: Wed, 7 Jun 2017 19:29:15 +0200 From: "O. Hartmann" <ohartmann@walstatt.org> To: Matthias Apitz <guru@unixarea.de> Cc: freebsd-current@freebsd.org Subject: Re: mount_smbfs gives error when stored crypted pw is used Message-ID: <20170607192915.28088b71@thor.intern.walstatt.dynvpn.de> In-Reply-To: <20170607172234.GA3972@c720-r314251> References: <20170606100034.GA4245@c720-r314251> <20170606123738.GA5213@c720-r314251> <20170607123531.GA4867@c720-r314251> <20170607172234.GA3972@c720-r314251>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/IEq3dtuK6wSBbPAQ_kW830V Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am Wed, 7 Jun 2017 19:22:34 +0200 Matthias Apitz <guru@unixarea.de> schrieb: > El d=C3=ADa mi=C3=A9rcoles, junio 07, 2017 a las 02:35:31p. m. +0200, Mat= thias Apitz escribi=C3=B3: >=20 > > I have located the bug in /usr/src/contrib/smbfs/lib/smb/subr.c=20 > >=20 > > The printf(3C) calls have been added for debugging; the bug is the > > addition of 13 after crypting every char which let the mask used in ^ o= peration > > exceeding 256, i.e. more than one byte, if the string to be crypted is = long > > enough. The two lines added: > >=20 > > if (pos > 256) > > pos =3D pos-256; > >=20 > > fixes this issue and the crypting/decypting works fine; see below; > >=20 > > I'll later file a PR and propose the patch; =20 >=20 > The PR was already made in 2009: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D132302 has a patch at= tached (nearly > the same solution as I have found), but was never ci'ed :-( >=20 > matthias >=20 >=20 Wow ... that is, simply ... not very good! :-( High quality! --=20 O. Hartmann Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Abs.= 4 BDSG). --Sig_/IEq3dtuK6wSBbPAQ_kW830V Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWTg36wAKCRDS528fyFhY lIHBAgCfzFwuQ/UXdq2gVYjnz8rp4zZIlujJVqDHPFgAqGcUbryVAFdMcT3QfJII EMUCFNdc7OYMGAvvGQhBo3CgWPihAf9vDr5h0fWFhKoWP5KBhszOKznai9OFrCqf HxpWLbgIRYumqJ6HN9zcscRA2zl3EuUsRVQufL0cPcMPbahqZy6K =WCxB -----END PGP SIGNATURE----- --Sig_/IEq3dtuK6wSBbPAQ_kW830V--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170607192915.28088b71>