From owner-svn-ports-head@freebsd.org Sun Jul 26 22:12:56 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ABF0399C82F for ; Sun, 26 Jul 2015 22:12:56 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from fep17.mx.upcmail.net (fep17.mx.upcmail.net [62.179.121.37]) by mx1.freebsd.org (Postfix) with ESMTP id 9B7321F7; Sun, 26 Jul 2015 22:12:54 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from edge03.upcmail.net ([192.168.13.238]) by viefep15-int.chello.at (InterMail vM.8.01.05.13 201-2260-151-135-20130320) with ESMTP id <20150726221158.UVYV21075.viefep15-int.chello.at@edge03.upcmail.net>; Mon, 27 Jul 2015 00:11:58 +0200 Received: from [192.168.0.23] ([178.84.134.112]) by edge03.upcmail.net with edge id xABx1q00D2Rg3Ey01ABxzl; Mon, 27 Jul 2015 00:11:58 +0200 X-SourceIP: 178.84.134.112 Subject: Re: svn commit: r392950 - head/multimedia/gstreamer1-plugins To: Tijl Coosemans , svn-ports-head@freebsd.org References: <201507262206.t6QM6xYY096085@repo.freebsd.org> From: Koop Mast Message-ID: <55B55B26.1040804@rainbow-runner.nl> Date: Mon, 27 Jul 2015 00:11:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <201507262206.t6QM6xYY096085@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jul 2015 22:12:56 -0000 Hi, I reverted the new regex. It also caught libraries it doesn't affect. So breaking gstreamer1-plugin-bad and after fiddling around to allow -bad to build it broke other plugins. So I decided to bring back the blob of sed lines. I do like the more light approach though, if you can come up with a variant that allows all plugins to build. I will be happy to test any patches in my poudriere if you don't have the way of doing that yourself. -Koop On 27-7-2015 0:06, Koop Mast wrote: > Author: kwm > Date: Sun Jul 26 22:06:58 2015 > New Revision: 392950 > URL: https://svnweb.freebsd.org/changeset/ports/392950 > > Log: > Revert r392917 and part of r392902 (to gstreamer1-plugins/Makefile). > > The new regex was too broad and broke the plugins from the -bad package. > > Modified: > head/multimedia/gstreamer1-plugins/Makefile > > Modified: head/multimedia/gstreamer1-plugins/Makefile > ============================================================================== > --- head/multimedia/gstreamer1-plugins/Makefile Sun Jul 26 21:54:32 2015 (r392949) > +++ head/multimedia/gstreamer1-plugins/Makefile Sun Jul 26 22:06:58 2015 (r392950) > @@ -137,9 +137,32 @@ post-patch: > .endif > .if ${DIST} != ugly > @${FIND} ${WRKSRC}/ext ${WRKSRC}/sys -name Makefile.in | \ > - ${XARGS} -n 10 ${REINPLACE_CMD} \ > - -e '/la_DEPENDENCIES/,/am__DEPENDENCIES/s,$$(top_builddir)/gst-libs/[^[:space:]]*\.la,,' \ > - -e 's|$$(top_builddir)/gst-libs/[^[:space:]]*/lib\([^/[:space:]]*\)\.la|-l\1|' > + ${XARGS} -n 10 ${REINPLACE_CMD} -e \ > + '/la_DEPENDENCIES/,/am__DEPENDENCIES/s,$$(top_builddir)/gst-libs/.*.la,,' -e \ > + 's|$$(top_builddir)/gst-libs/gst/tag/libgsttag-@GST_API_VERSION@.la|-lgsttag-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/audio/libgstaudio-@GST_API_VERSION@.la|-lgstaudio-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/pbutils/libgstpbutils-@GST_API_VERSION@.la|-lgstpbutils-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/riff/libgstriff-@GST_API_VERSION@.la|-lgstriff-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/signalprocessor/libgstsignalprocessor-@GST_API_VERSION@.la|-lgstsignalprocessor-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-@GST_API_VERSION@.la|-lgstbasevideo-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-@GST_API_VERSION@.la|-lgstvideo-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-@GST_API_VERSION@.la|-lgstbadbase-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/uridownloader/libgsturidownloader-@GST_API_VERSION@.la|-lgsturidownloader-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-@GST_API_VERSION@.la|-lgstbadvideo-${VERSION}|' > + > + @${FIND} ${WRKSRC}/ext ${WRKSRC}/sys -name Makefile.in | \ > + ${XARGS} -n 10 ${REINPLACE_CMD} -e \ > + '/la_DEPENDENCIES/,/am__DEPENDENCIES/s,$$(top_builddir)/gst-libs/.*.la,,' -e \ > + 's|$$(top_builddir)/gst-libs/gst/tag/libgsttag-$$(GST_API_VERSION).la|-lgsttag-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/audio/libgstaudio-$$(GST_API_VERSION).la|-lgstaudio-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/pbutils/libgstpbutils-$$(GST_API_VERSION).la|-lgstpbutils-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/riff/libgstriff-$$(GST_API_VERSION).la|-lgstriff-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/signalprocessor/libgstsignalprocessor-$$(GST_API_VERSION).la|-lgstsignalprocessor-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstbasevideo-$$(GST_API_VERSION).la|-lgstbasevideo-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstvideo-$$(GST_API_VERSION).la|-lgstvideo-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/base/libgstbadbase-$$(GST_API_VERSION).la|-lgstbadbase-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/uridownloader/libgsturidownloader-$$(GST_API_VERSION).la|-lgsturidownloader-${VERSION}|; \ > + s|$$(top_builddir)/gst-libs/gst/video/libgstbadvideo-$$(GST_API_VERSION).la|-lgstbadvideo-${VERSION}|' > .endif > > # workaround a crash in clang 3.3 crash llvm bug # 15840 >