Date: Tue, 2 Apr 2019 11:50:56 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs Message-ID: <1590D5B3-58F2-4086-8717-804AB5F89B69@gmail.com> In-Reply-To: <CAOtMX2inJJk8Hr-TUpUzX3L=afufiq2oFfdZ8i4H8CvVUveFyw@mail.gmail.com> References: <201904021844.x32Ii1wR041319@repo.freebsd.org> <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> <CAOtMX2inJJk8Hr-TUpUzX3L=afufiq2oFfdZ8i4H8CvVUveFyw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 2, 2019, at 11:49 AM, Alan Somers <asomers@FreeBSD.org> wrote: >=20 > On Tue, Apr 2, 2019 at 12:45 PM Enji Cooper <yaneurabeya@gmail.com> = wrote: >>=20 >>=20 >>> On Apr 2, 2019, at 11:44 AM, Alan Somers <asomers@FreeBSD.org> = wrote: >>>=20 >>> Author: asomers >>> Date: Tue Apr 2 18:44:01 2019 >>> New Revision: 345809 >>> URL: https://svnweb.freebsd.org/changeset/base/345809 >>>=20 >>> Log: >>> fusefs: check return value of wait(2) in fork tests >>>=20 >>> Reported by: ngie >>> Sponsored by: The FreeBSD Foundation >>>=20 >>> Modified: >>> projects/fuse2/tests/sys/fs/fusefs/utils.cc >>>=20 >>> Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:09:40 2019 (r345808) >>> +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 = 18:44:01 2019 (r345809) >>> @@ -321,7 +321,7 @@ out: >>> /* Signal the child process to go */ >>> ASSERT_EQ(0, sem_post(sem)) << strerror(errno); >>>=20 >>> - wait(&child_status); >>> + ASSERT_LE(0, wait(&child_status)) << strerror(errno); >>=20 >> Don=E2=80=99t you want ASSERT_GE here, since you=E2=80=99re testing = that wait succeeded? >> -Enji >=20 > Opposite operand order. I'm asserting that 0 is less than or equal to > wait's return value. Ah, yes. Derp. Thank you for correcting me on that :D. -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1590D5B3-58F2-4086-8717-804AB5F89B69>