Date: Sun, 29 Jul 2007 14:42:24 -0700 (PDT) From: mjacob@freebsd.org To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c Message-ID: <20070729143653.E86313@ns1.feral.com> In-Reply-To: <20070729211359.C31116@maildrop.int.zabbadoz.net> References: <200707290131.l6T1VY8g026872@repoman.freebsd.org> <46AC987A.9040501@freebsd.org> <20070729184123.S44136@mp2.macomnet.net> <20070729095743.N84864@ns1.feral.com> <20070729101357.A84864@ns1.feral.com> <20070729101935.D84864@ns1.feral.com> <20070729211359.C31116@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote: > On Sun, 29 Jul 2007, mjacob@freebsd.org wrote: > >> Here's what probably works. I'll do the test compiles. > > If I am not wrong it will not. > > The follwoing two files have comments at the beginning to explain the > changes. > I don't like the extern char *tcpstates[] but it seems to be the best > solution for now. No, that's what's actually wrong. tcpstates has to be static to honor the intent of the original author. If you want to do something extern then the actual tcpstates should go into tcp_debug.c. However, this is slightly less flexible in that the way it is now each source file can include this array simply by defining TCPSTATES (independent of TCPDEBUG as an option). This is all incredible microopt goop. The only reason I didn't just simply make this an always visible thing is that it really dates to all intents and purposes from the end of the PDP-11 era where the inclusion of this array or not was really worth worrying about.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070729143653.E86313>