Date: Wed, 09 May 2007 00:05:20 -0700 From: Nate Lawson <nate@root.org> To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c Message-ID: <464172B0.4010507@root.org> In-Reply-To: <86lkfzm2m7.fsf@dwp.des.no> References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> <86tzurqp4d.fsf@dwp.des.no> <864pmn5lvd.fsf@dwp.des.no> <4640D8AA.40101@root.org> <86lkfzm2m7.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Nate Lawson <nate@root.org> writes: >> BTW, is there any reason to redo the "MODE S" and "TYPE I" commands >> after MDTM? > > MODE and TYPE commands are always issued before an MDTM (fetchStat*()) > or RETR (fetchGet*()), because the code assumes that they can vary > from one call to another. This is true for TYPE (you can specify it > in the URL), and I chose to assume that it might also be the case for > MODE, even though it currently isn't. > > (remember that the FTP code will reuse the control connection across > calls as long as the requested URLs are on the same server) Could it be possible to check the values from the URL used to derive TYPE for RETR and then if it's the same as the value for MDTM, don't reissue it? Same for MODE. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?464172B0.4010507>