From owner-freebsd-current@freebsd.org Sat Feb 10 23:10:48 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB84DF0523E for ; Sat, 10 Feb 2018 23:10:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3E03A77D49; Sat, 10 Feb 2018 23:10:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x230.google.com with SMTP id h78so8717329lfg.6; Sat, 10 Feb 2018 15:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6WjHk9gKH4eEXlhf/G4HJ2zeTsk67kDgnNTOLGH2bDQ=; b=rk3hU66uZxzH8FO1dLdH0MXUncNlsT/7XC8KzUQgbqiKPAba/BJMryAvByNZ9fH1Mu jUsulo0ZyUSIY+rVBdU+vXhtvVAXb4ba8RpFVke6KHmKmSPSgKArTP0aT0uobbofVQjR 26SWQ0sZyHCzKy1TsA4KQ/g7CDpCjYz7WmijKfhWFYhHejUj9gRkMLoTXsHnLWHkedT7 mGokO9cBl9zT5egGaKyv/qCVTezLfHECTaKN1RYzlvsc4zWRyiefmxjWO6I/W6PSOYLH Hp2sozDbKl0lOnsZ1uH38HzOkz7ygdg3Lo3TjlNtSE74vbHcn91NANkLHpKAV64xTS5d ZW+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6WjHk9gKH4eEXlhf/G4HJ2zeTsk67kDgnNTOLGH2bDQ=; b=RrAl5NLIMHhJ47uKhyJ1SgQzrHr15oO7m6FGvnEQiS6kh+3LhobWtrChXcHHHajSrY g8Pb6hnr1DHWelBiB030eEycZ05PMgy8glSRN8IVrQR6MGN+BwkavRfHOYbSNz0hIooX b2zY3NhYRlA7FwKKGfwSTMl7gjxNc8eUSihaz3xhK3Az3iHmmFBnZWBwDartDcx2e4Of fGWxH3SjGd6QgQW7Ubv5hrTObV4m3yp7Zk6x9li/bLEVjIU4HKglA7w+U6CzyiW054GL KVM9hBmtdcUYoLmUrN34zPTRYs1qg+BJaaOSlzUbroHKyfko0czGq1xpST8qvL6P/VN2 Pq7Q== X-Gm-Message-State: APf1xPAyfAPQJ7UcOaNdN7l6yJxoypEL3jwxa++OEnsGuCqTs0idKEbF gCYL8peKVEDTpXgq/eZiOcnxUTzxVNvQmsYiZ/exCQ== X-Google-Smtp-Source: AH8x227iQFn152RHW9G9db5m6Qs5AE4qEqbUXx96lx7lYqLGaVhnEkSUdmhjRyJIB4R1/o7E1P+jnR6AWTRAENRRCzA= X-Received: by 10.46.22.30 with SMTP id w30mr4391627ljd.91.1518304245529; Sat, 10 Feb 2018 15:10:45 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.87.131 with HTTP; Sat, 10 Feb 2018 15:10:44 -0800 (PST) In-Reply-To: <4fa8de06-c7a0-5585-4fa7-5bf59b99d627@digiware.nl> References: <1e2f43fd-85da-6629-62d1-6e96790278e5@digiware.nl> <1518291799.32585.228.camel@freebsd.org> <4fa8de06-c7a0-5585-4fa7-5bf59b99d627@digiware.nl> From: Alan Somers Date: Sat, 10 Feb 2018 16:10:44 -0700 X-Google-Sender-Auth: kEQv74y7qryye-snDCVd_E3D5p0 Message-ID: Subject: Re: posix_fallocate on ZFS To: Willem Jan Withagen Cc: Ian Lepore , freebsd current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2018 23:10:48 -0000 On Sat, Feb 10, 2018 at 3:50 PM, Willem Jan Withagen wrote: > On 10/02/2018 20:43, Ian Lepore wrote: > >> On Sat, 2018-02-10 at 11:24 -0700, Alan Somers wrote: >> >>> On Sat, Feb 10, 2018 at 10:28 AM, Willem Jan Withagen >>> wrote: >>> >>> >>>> Hi, >>>> >>>> This has been disabled on ZFS since last November. >>>> And I do understand the rationale on this. >>>> >>>> BUT >>>> >>>> I've now upgraded some of my HEAD Ceph test systems and they now fail, >>>> since Ceph uses posix_fallocate() to allocate space for the >>>> FileStore-journal. >>>> >>>> Is there any expectation that this is going to fixed in any near future? >>>> >>>> --WjW >>>> >>>> No. It's fundamentally impossible to support posix_fallocate on a COW >>> filesystem like ZFS. Ceph should be taught to ignore an EINVAL result, >>> since the system call is merely advisory. >>> >>> -Alan >>> >> >> Unfortunately, posix documents that the function returns EINVAL only >> due to bad input parameters, so ignoring that seems like a bad idea. >> >> Wouldn't it be better if we returned EOPNOTSUP if that's the actual >> situation? That could be safely ignored. >> > > I would probably help in my situation.... > > And I've been looking at the manpage, but cannot seem to find any > indication that EINVAL is returned on running it on FreeBSD. > It's in the manpage, but only on head. It hasn't been in any stable release yet. https://svnweb.freebsd.org/base/head/lib/libc/sys/posix_fallocate.2?revision=325422&view=markup#l112