Date: Fri, 23 Jul 1999 10:10:58 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Mike Smith <mike@smith.net.au> Cc: Peter Jeremy <jeremyp@gsmx07.alcatel.com.au>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, jkh@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall tcpip.c Message-ID: <33651.932717458@critter.freebsd.dk> In-Reply-To: Your message of "Thu, 22 Jul 1999 17:30:24 PDT." <199907230030.RAA03011@dingo.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I would advocate the ether_input API. I have never heard of a 3rd party ethernet driver, and considering the number of changes we introduce between 3.x and 4.x anyway, driver compatibility is already pretty much shot anyway, so I think we should fix the API to do it "right" rather than fight for a compatibility which is at best of only marginal advantage to anybody. Poul-Henning In message <199907230030.RAA03011@dingo.cdrom.com>, Mike Smith writes: >> That is really a deficiency of our ethernet layer (on my todo-list >> way down there...) Each ethernet driver shouldn't have to know >> as much as it does about the input path for packets, or for that >> matter if bpf is there or not. > >The basic problem here is that bpf et. al. want the whole datagram, >while ether_input wants it broken up into the header and body. > >There are two approaches we can take here; either we change ether_input >to take the raw packet (alters the driver API) or we shim bpf to >reconstruct the packet. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33651.932717458>