From owner-cvs-all Mon Apr 15 9: 2:16 2002 Delivered-To: cvs-all@freebsd.org Received: from south.nanolink.com (south.nanolink.com [217.75.134.10]) by hub.freebsd.org (Postfix) with SMTP id EF72337B423 for ; Mon, 15 Apr 2002 09:01:55 -0700 (PDT) Received: (qmail 25895 invoked from network); 15 Apr 2002 16:07:22 -0000 Received: from unknown (HELO straylight.ringlet.net) (212.116.140.125) by south.nanolink.com with SMTP; 15 Apr 2002 16:07:22 -0000 Received: (qmail 12602 invoked by uid 1000); 15 Apr 2002 15:27:23 -0000 Date: Mon, 15 Apr 2002 18:27:23 +0300 From: Peter Pentchev To: Mike Silbersack Cc: kde@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.h Message-ID: <20020415182723.C358@straylight.oblivion.bg> Mail-Followup-To: Mike Silbersack , kde@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <20020415163243.A358@straylight.oblivion.bg> <20020415164937.B4934-100000@patrocles.silby.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="s2ZSL+KKDSLx8OML" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020415164937.B4934-100000@patrocles.silby.com>; from silby@silby.com on Mon, Apr 15, 2002 at 04:51:12PM -0500 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --s2ZSL+KKDSLx8OML Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 15, 2002 at 04:51:12PM -0500, Mike Silbersack wrote: >=20 >=20 > On Mon, 15 Apr 2002, Peter Pentchev wrote: >=20 > > Well, it seems that this was indeed unused in the base system, > > but I think the attached patch will be needed now for the games/kdegame= s2 > > port :) > > > > --- ksirtet/lib/wizard.cpp.old Mon Apr 15 16:15:44 2002 > > +++ ksirtet/lib/wizard.cpp Mon Apr 15 16:18:27 2002 > > @@ -24,7 +24,7 @@ > > #ifdef __bsdi__ > > #define IPPORT_USERRESERVED IPPORT_DYNAMIC > > #endif > > -#if defined(__NetBSD__) || defined(__sgi) > > +#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__sgi) > > #define IPPORT_USERRESERVED IPPORT_RESERVED >=20 > I'll have to try installing that port and looking at how > IPPORT_USERRESERVED was being used. I can tall you from a quick glance > that the patch above is _not_ correct! IPPORT_USERRESERVED equalled 5000, > IPPORT_RESERVED =3D=3D 1024. >=20 > I have no clue why those definitions were being used in the first place in > a kde game either way. Well, ksirtet is a Tetris clone with network multiplayer capabilities; to host a server, you need to give it a port number to bind to. IPPORT_RESERVED is used as MIN_USER_PORT, so that the game kind of ensures that you enter a port in a (somewhat) valid range that it can bind to, when running as a normal user. I know that defining IPPORT_USERRESERVED as IPPORT_RESERVED will not give the same functionality as before, but it will give *some* working functionality - the game will be able to exercise a minimal validation of user input. Of course, it would be perfect to make it use sysctl's, but that might well be overkill for a kde game :)) G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 If I were you, who would be reading this sentence? --s2ZSL+KKDSLx8OML Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjy68VsACgkQ7Ri2jRYZRVPgzwCfTy27HsKqYB7m4UVa5QLaIxOv XH0AoKvUWSy4AQ+ijHUVhmUP9dLcZHse =Re6T -----END PGP SIGNATURE----- --s2ZSL+KKDSLx8OML-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message