Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Aug 2019 08:42:29 +0200
From:      Alexander Leidinger <netchild@freebsd.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r508967 - in head/security: . bastillion bastillion/files
Message-ID:  <20190816084229.Horde.8U0fEbjob6nF20UAn8gQciY@webmail.leidinger.net>
In-Reply-To: <20190814204340.utfrxbvrbt5wwt24@atuin.in.mat.cc>
References:  <201908142036.x7EKaV7Z080059@repo.freebsd.org> <20190814204340.utfrxbvrbt5wwt24@atuin.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format and has been PGP signed.

--=_4yZ45bbtMPBpXLZa-UfTCE-
Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Quoting Mathieu Arnold <mat@freebsd.org> (from Wed, 14 Aug 2019=20=20
22:43:40=20+0200):

> On Wed, Aug 14, 2019 at 08:36:31PM +0000, Alexander Leidinger wrote:
>> +PORTNAME=3D		bastillion
>> +PORTVERSION=3D		3.06.04
>> +DVERSION=3D		3.06_04
>> +DISTVERSIONPREFIX=3D	v
>> +#PKGNAMESUFFIX=3D		0
>> +CATEGORIES=3D		security www java
>> +MASTER_SITES=3D		https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/release=
s/download/${GH_TAGNAME}/
>> +DISTNAME=3D		${PORTNAME}-jetty-v${DVERSION}
>
> This should probably be written as:
>
> PORTNAME=3D		bastillion
> DISTVERSIONPREFIX=3D	jetty-v
> DISTVERSION=3D		3.06_04
> CATEGORIES=3D		security www java
> MASTER_SITES=3D		https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/releases/=
download/v${DISTVERSION}/

Hmmm... in my initial tests I had DISTVERSION, but then the version of=20=
=20
the=20port was with an underscore. Testing this now it doesn't show the=20=
=20
underscore,=20it shows all dots... strange.
FYI: MASTER_SITES needs to have PORTVERSION, not DISTVERSION.

Thanks for the suggestion, I will commit it in a few seconds...

Bye,
Alexander.
--=20
http://www.Leidinger.net=20Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    netchild@FreeBSD.org  : PGP 0x8F31830F9F2772BF

--=_4yZ45bbtMPBpXLZa-UfTCE-
Content-Type: application/pgp-signature
Content-Description: Digitale PGP-Signatur
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJdVlBVAAoJEBINsJsD+NiGpqYP/ijxwEjfHvbov+ezrZ9uMEe4
68ijUvHJYbGNhi/lI6BbpxxRBSsY2u3dtvhGOul6iWF6cHmIDz7J/GYdpuLDLsR5
VB6LoqglAPRMCt3Ln3RaVkAjKyGEyai2Cen5P5z4jNLs5SjAnU1uUOi/5/vF35Lx
daeemC0PgRBT8/RGMubmmItSoQprUPZaaiXchr1ZDhd6q81PLFRTxCPIdxJUQMMM
PvTwB5aT0LbZWDhdqy5lo4O4VsSDa1ALP0ptSv6T6PMSfRdJZKgnYqOTKR5Sz+i3
bJ2Q2yT1fFZE9VVLpwllyv//4LMWCEd0oExoXA7pPnuZsfx9RYxvA3Kggw4tS529
6M3PE4Q0Cfh538M5WiViUFn5V8ow3A55MzvliHLhi1KA6/8DqTgdoBAp7rkImTF+
H61D3fxYINhcD/3q7YOsEGhALGW0srSMJPiQghAB65fgbuUNMT1EpxSC3vbqYQbt
4KZ1GbmUnMuZjZvIdW8JQmrNrmM15KPrsF7bQnJ9VetBawPRQ9LddelNMI92aQb/
J0hx5XmISGSyzWY7gsjW+60DmVj8XtFLd0OCdd24yGJxEKHPXkKlKhpvA48mbm14
B5EivVA0mGOaaaXB0aJ9UGVaQiiMBk7uHHBWcEGjZ4+49HhUBwQ6JrCrcVbbRefP
jka0sPoFaVKFBXK1rJ4f
=QsEU
-----END PGP SIGNATURE-----

--=_4yZ45bbtMPBpXLZa-UfTCE---



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190816084229.Horde.8U0fEbjob6nF20UAn8gQciY>