Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Oct 2018 17:47:24 +0200
From:      =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org>
To:        adamw@adamw.org
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r481995 - in head/math: . cddlib
Message-ID:  <CAGwOe2bihfb6ZSucU%2BNK123tha9B0%2B6iyOrUtNPGT6mkj5hLtQ@mail.gmail.com>
In-Reply-To: <CAP7rwchh8NHfoW3wgP9-=bXA7NjiCb5gvcuFww80ycJgXBU=Sg@mail.gmail.com>
References:  <201810131629.w9DGTjm1068279@repo.freebsd.org> <CAP7rwchh8NHfoW3wgP9-=bXA7NjiCb5gvcuFww80ycJgXBU=Sg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 13, 2018 at 7:14 PM Adam Weinberger <adamw@adamw.org> wrote:
>
> On Sat, Oct 13, 2018 at 10:29 AM Fernando Apestegu=C3=ADa
> <fernape@freebsd.org> wrote:
> >
> > Author: fernape
> > Date: Sat Oct 13 16:29:45 2018
> > New Revision: 481995
> > URL: https://svnweb.freebsd.org/changeset/ports/481995
> >
> > Log:
> >   New port: math/cddlib
> >
> >   C implementation of the Double Description Method of Motzkin et al
> >
> >   PR:   231161
> >   Submitted by: phascolarctos@protonmail.ch
> >   Reviewed by:  tcberner (mentor, implicit)
> >   Differential Revision:        https://reviews.freebsd.org/D17385
> >
> > Added:
> >   head/math/cddlib/
> >   head/math/cddlib/Makefile   (contents, props changed)
> >   head/math/cddlib/distinfo   (contents, props changed)
> >   head/math/cddlib/pkg-descr   (contents, props changed)
> >   head/math/cddlib/pkg-plist   (contents, props changed)
> > Modified:
> >   head/math/Makefile
> >
> > Modified: head/math/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/math/Makefile  Sat Oct 13 15:56:02 2018        (r481994)
> > +++ head/math/Makefile  Sat Oct 13 16:29:45 2018        (r481995)
> > @@ -150,6 +150,7 @@
> >      SUBDIR +=3D cbc
> >      SUBDIR +=3D cblas
> >      SUBDIR +=3D ccmath
> > +    SUBDIR +=3D cddlib
> >      SUBDIR +=3D ceres-solver
> >      SUBDIR +=3D cgal
> >      SUBDIR +=3D cgl
> >
> > Added: head/math/cddlib/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/math/cddlib/Makefile   Sat Oct 13 16:29:45 2018        (r48199=
5)
> > @@ -0,0 +1,50 @@
> > +# $FreeBSD$
> > +
> > +PORTNAME=3D      cddlib
> > +PORTVERSION=3D   0.94j
> > +CATEGORIES=3D    math
> > +
> > +MAINTAINER=3D    phascolarctos@protonmail.ch
> > +COMMENT=3D       C implementation of the Double Description Method of =
Motzkin et al
> > +
> > +LICENSE=3D       GPLv2+
> > +LICENSE_FILE=3D  ${WRKSRC}/COPYING
> > +
> > +LIB_DEPENDS=3D   libgmp.so:math/gmp
> > +
> > +USES=3D          autoreconf gmake libtool:build localbase:ldflags
> > +USE_LDCONFIG=3D  yes
> > +USE_GITHUB=3D    yes
> > +GH_ACCOUNT=3D    cddlib
> > +
> > +GNU_CONFIGURE=3D yes
> > +
> > +OPTIONS_DEFINE=3D        MANUAL EXAMPLES
> > +OPTIONS_SUB=3D   yes
> > +MANUAL_DESC=3D   User manual (many dependencies, including texlive)
> > +MANUAL_BUILD_DEPENDS=3D  latex:print/tex-formats \
> > +                       dvips:print/tex-dvipsk
> > +
> > +HEADERSDIR=3D    ${PREFIX}/include/cdd
> > +
> > +pre-build-MANUAL-off:
> > +       ${REINPLACE_CMD} 's,doc lib-src,lib-src,' ${WRKSRC}/Makefile.am
> > +
> > +do-install:
> > +       ${MKDIR} ${STAGEDIR}${HEADERSDIR}
> > +       cd ${WRKSRC}/src/.libs && ${COPYTREE_BIN} . ${STAGEDIR}${PREFIX=
}/bin
> > +       cd ${WRKSRC}/lib-src/.libs && ${COPYTREE_BIN} . ${STAGEDIR}${PR=
EFIX}/lib '-name *\.so*'
>
> COPYTREE_BIN looks wrong here. Why should libraries be executable?

Fixed in r481998

Thanks for pointing this out.

>
> # Adam
>
>
>
> --
> Adam Weinberger
> adamw@adamw.org
> https://www.adamw.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2bihfb6ZSucU%2BNK123tha9B0%2B6iyOrUtNPGT6mkj5hLtQ>