Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Aug 2004 14:12:40 -0700
From:      Nate Lawson <nate@root.org>
To:        "M. Warner Losh" <imp@bsdimp.com>
Cc:        cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/fdc fdc_acpi.c
Message-ID:  <4134E9C8.4020502@root.org>
In-Reply-To: <20040831.144338.66325058.imp@bsdimp.com>
References:  <200408302135.i7ULZYQx028502@repoman.freebsd.org> <20040831070313.GC30959@ip.net.ua>	<4134A9E9.7090008@root.org> <20040831.144338.66325058.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
M. Warner Losh wrote:
> In message: <4134A9E9.7090008@root.org>
>             Nate Lawson <nate@root.org> writes:
> : Ruslan Ermilov wrote:
> : > On Mon, Aug 30, 2004 at 09:35:34PM +0000, Nate Lawson wrote:
> : > 
> : >>njl         2004-08-30 21:35:34 UTC
> : >>
> : >>  FreeBSD src repository
> : >>
> : >>  Modified files:
> : >>    sys/dev/fdc          fdc_acpi.c 
> : >>  Log:
> : >>  Fix _FDI drive type probing.  The new fd child is not an ACPI device while
> : >>  the old one is.  Hence we need to evaluate the old one for _FDI since it
> : >>  has a valid ACPI_HANDLE ivar.  This is a minimal fix.  Make a note that a
> : >>  more complete one is to make fdc support the ACPI_HANDLE ivar for its
> : >>  children.
> : >>  
> : >>  This and the previous change are MT5 candidates.
> : >>  
> : >>  Revision  Changes    Path
> : >>  1.5       +10 -3     src/sys/dev/fdc/fdc_acpi.c
> : >>
> : > 
> : > Should I retry on my ThinkPad 600X with these two changes?
> : 
> : Sure but I think yours was a resource problem and you don't have _FDE 
> : probing.
> 
> I'm working the resource problem right now...

My hero.  :)

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4134E9C8.4020502>