Date: Sun, 9 Feb 2014 14:37:56 +0100 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r343457 - head/audio/p5-Shout Message-ID: <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org> In-Reply-To: <D51FCA4F34828A264C471DCA@atuin.in.mat.cc> References: <201402091101.s19B1aPh072112@svn.freebsd.org> <1E1640591FF296C66F82EF62@atuin.in.mat.cc> <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org> <D51FCA4F34828A264C471DCA@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> wrote:
> +--On 9 f=E9vrier 2014 13:16:26 +0100 Emanuel Haupt <ehaupt@FreeBSD.org>
> wrote:
> | Mathieu Arnold <mat@FreeBSD.org> wrote:
> |>=20
> |>=20
> |> +--On 9 f=E9vrier 2014 11:01:36 +0000 Emanuel Haupt
> |> <ehaupt@FreeBSD.org> wrote:
> |> | +.include <bsd.port.options.mk>
> |> | +
> |> | post-install:
> |> | -.ifndef(NOPORTDOCS)
> |> | - @${MKDIR} ${DOCSDIR}
> |> | - ${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${DOCSDIR}
> |> | -.endif
> |> | + ${STRIP_CMD} ${STAGEDIR}
> |> | ${SITE_PERL}/${PERL_ARCH}/auto/Shout/Shout.so
> |> | + ${MKDIR} ${STAGEDIR}${DOCSDIR}
> |> | + ${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> |> | ${DOCSDIR}=20
> |> | .include <bsd.port.mk>
> |>=20
> |> What do you need bsd.port.options.mk for ?
> |=20
> | I think it's required for dealing with the conditional installation
> | of:
> |=20
> | ${MKDIR} ${STAGEDIR}${DOCSDIR}
> | ${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> | ${DOCSDIR}
>=20
> Yes, and like the wiki[1] says, unless there's a tremendous number of
> files and the IO hit is pretty severe you should install them always.
So you agree with me that the inclusion is required?
> (Also, if those are examples, they should go in EXAMPLESDIR)
I was simply looking at the aspect of converting the port to support
staging. I don't know if the application requires the files to be
installed in EXAMPLESDIR or DOCSDIR.
Emanuel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140209143756.c1bc46e172d5d5c8979787fc>