From owner-svn-src-all@FreeBSD.ORG  Sat May 23 11:27:50 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D172A106564A;
	Sat, 23 May 2009 11:27:50 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au
	[211.29.132.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E90B8FC14;
	Sat, 23 May 2009 11:27:50 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c122-107-117-19.carlnfd1.nsw.optusnet.com.au
	(c122-107-117-19.carlnfd1.nsw.optusnet.com.au [122.107.117.19])
	by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n4NBRlKu001440
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 23 May 2009 21:27:48 +1000
Date: Sat, 23 May 2009 21:27:46 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Sam Leffler <sam@FreeBSD.org>
In-Reply-To: <4A16F40B.4020404@freebsd.org>
Message-ID: <20090523210556.Y826@delplex.bde.org>
References: <200905221810.n4MIAe4J014419@svn.freebsd.org>
	<20090522184846.GA34437@FreeBSD.org> <4A16F40B.4020404@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, Rick Macklem <rmacklem@FreeBSD.org>,
	Alexey Dokuchaev <danfe@FreeBSD.org>, src-committers@FreeBSD.org,
	svn-src-all@FreeBSD.org
Subject: Re: svn commit: r192591 - head/sys/fs/nfsserver
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 May 2009 11:27:51 -0000

On Fri, 22 May 2009, Sam Leffler wrote:

> Alexey Dokuchaev wrote:
>> On Fri, May 22, 2009 at 06:10:40PM +0000, Rick Macklem wrote:
>>> ...
>>> Log:
>>>   Modified the printf message of r192590 to remove the
>>>   possible DOS attack, as suggested by Sam.
>>>   -	printf("out of clientids, possible DOS attack\n");
>>> +	printf("out of clientids\n");
>>> 
>> 
>> Previously, panic() message referred "nfs4", now it does not, making it
>> rather cryptic without grepping through the source code.
>> .
> I requested the printf identify the call site; e.g.
>
> printf("%s: out of clientids\n", __func__);

That is equally cryptic _with_ grepping through the source code, and
much uglier.  __func__ should only be used when the function name is
not a literal constant (mainly in macros).  The new nfs code only uses
__func__ in 2 places, now including this one.  The old nfs code only
uses it in a few more than 2 places.

Bruce