From owner-svn-src-all@freebsd.org Mon Jul 16 18:21:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53EBF10341AB for ; Mon, 16 Jul 2018 18:21:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D379C7CB81 for ; Mon, 16 Jul 2018 18:21:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id q4-v6so38729655iob.2 for ; Mon, 16 Jul 2018 11:21:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=br4eHWhhzxqDnaNahEKYlicSV7XO9hnwH/yx3JqM+Ls=; b=jswqKIYG5QVpnv8d0h8z+FbBdyV4pap5QDDEolq8cEYuiFTBk7DhlKuLAppoOnjZEn ik9AJ+HCd00mh91RNMVQHHAMYEXHivqz1+KfBujAc+6CRyF9HfZk3VlM7bgJuMj5XnF/ eC4t3WAcJV2EmAj2SXJP/AupYnI03LzfRrcqcbaOyNB+TSvKbH/IzBC1FN6iL22mtUZs RDnVKx9EoLVxanqinNUXwatB4z3DrKF5DWqmh3/7Dp+IyxYx8nhtSAWvvI8JyC/iI//a KxldVDoXua5kGek4jy1yuoRKOaSjRZgLAp8s0YFsBx/azK8GCcgqadzm5AGBeGlX0ZJX RVCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=br4eHWhhzxqDnaNahEKYlicSV7XO9hnwH/yx3JqM+Ls=; b=mKcVs5Be3PWzm68RX3jXnTO39z83roK0nfkFxivLPIh828S2cw4APioSjMODnrsPaB X926d01TYfof9z2joEWReUeSlS35iA+WYNlq8G548B9TH/bsm4jB0akFpdD0IlBVrYyO T28pz7aLMQrpzqV8PX7bAViMqTfRSiRkJ+Kr47lAjgaglHp/p0Kbk3CK+XR2jGhZPUA+ Rzc/BEEQJxby6ySkbuO/FTv635zFLekZuU3/NKXDnyOatje2B6HUaQXngfaeOKnCKYua geFVW2Ra9p0yajJKXaIBu+KcOwrC09SZHIUh58z5q/Dg8F745FKkRNig/7x7X9rybHzH lBBA== X-Gm-Message-State: AOUpUlGheYtEbaYc1hOXkk0/Nik+X/r4noPyV7dnE7QnCUTkecL3Qrzd WrgJNS1tuCcnrZSRZa1/RizMPO+fGMn6mtRO50Fjfg== X-Google-Smtp-Source: AAOMgpdxjojM8bdP8VP6kDqmAdM6J20vFhyRb5UprSlpUw8JQCtomvpeddMbgB7JxUjStstx6hZtnjwtTrg0/RUefm0= X-Received: by 2002:a6b:f719:: with SMTP id k25-v6mr10293675iog.37.1531765271070; Mon, 16 Jul 2018 11:21:11 -0700 (PDT) MIME-Version: 1.0 References: <201807160134.w6G1YkNR038303@repo.freebsd.org> <829a4a12-20d1-e48d-c338-9dd3f67a3969@FreeBSD.org> In-Reply-To: <829a4a12-20d1-e48d-c338-9dd3f67a3969@FreeBSD.org> From: Warner Losh Date: Mon, 16 Jul 2018 12:20:59 -0600 Message-ID: Subject: Re: svn commit: r336326 - head/sys/dev/ichiic To: John Baldwin Cc: Oleksandr Tymoshenko , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 18:21:12 -0000 On Mon, Jul 16, 2018, 10:57 AM John Baldwin wrote: > On 7/15/18 6:34 PM, Oleksandr Tymoshenko wrote: > > Author: gonzo > > Date: Mon Jul 16 01:34:45 2018 > > New Revision: 336326 > > URL: https://svnweb.freebsd.org/changeset/base/336326 > > > > Log: > > Remove MODULE_PNP_INFO for ig4(4) driver > > > > ig4(4) does not support suspend/resume but present on the hardware > where > > such functionality is critical, like laptops. Remove PNP info to avoid > > breaking suspend/resume on the systems where ig4(4) load is not > explicitly > > requested by the user. > > > > PR: 229791 > > Reported by: Ali Abdallah > > I wonder if we don't want instead a way to tag a module as "don't autoload" > so that you can still have a way to say "show me which unprobed devices > have modules available". One option would be to have an rc.conf knob which > is a regex that gets used with 'egrep -v' in the rc.d script on the output > of devmatch. This has the slight advantage that a user can customize it > via rc.conf. (For example, when working on cxgbe(4) on my dev boxes I > don't > want it to autoload, but in a production environment we might want it to > autoload by default.) Another option might be to add some new type of > PNP info that is a boolean "autoload" that defaults to true and teach > devmatch to honor the boolean. > How does this break suspend / resume? That makes no sense to me at all. I think if this changes anything, it only we could fix that by accident. I get wanting to have a blacklist, but that belongs in rc, not the driver. That's on my soon list. But I need to implement the freeze thaw of proving first so I can re.ove the ugly kludge for usb first so we can filter again. We also need a newbus flag that says the device has been attached at least once so kldunload works... Warner >