From owner-svn-ports-head@FreeBSD.ORG Sun Dec 29 02:17:15 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0D83E5E; Sun, 29 Dec 2013 02:17:15 +0000 (UTC) Received: from b2bfep15.mx.upcmail.net (b2bfep15.mx.upcmail.net [62.179.121.60]) by mx1.freebsd.org (Postfix) with ESMTP id 866451DE5; Sun, 29 Dec 2013 02:17:13 +0000 (UTC) Received: from edge12.upcmail.net ([192.168.13.82]) by b2bfep16-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20131229015503.FBD17136.b2bfep16-int.chello.at@edge12.upcmail.net>; Sun, 29 Dec 2013 02:55:03 +0100 Received: from iznogoud.viz ([91.119.127.191]) by edge12.upcmail.net with edge id 7Dv21n00M47u4y30CDv3PS; Sun, 29 Dec 2013 02:55:03 +0100 X-SourceIP: 91.119.127.191 Received: from wolfgang by iznogoud.viz with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1Vx5ao-000AIa-FZ; Sun, 29 Dec 2013 02:55:02 +0100 From: Wolfgang Jenkner To: Boris Samorodov Subject: Re: svn commit: r337610 - in head/print: foomatic-db foomatic-db-engine foomatic-db/files foomatic-filters Date: Sun, 29 Dec 2013 02:45:36 +0100 References: <201312261938.rBQJcH4x042285@svn.freebsd.org> Message-ID: <85eh4wbevd.fsf@iznogoud.viz> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2013 02:17:15 -0000 On Thu, Dec 26 2013, Boris Samorodov wrote: > . take maintainership print/foomatic-db, print/foomatic-db-engine, print/foomatic-filters); > . update to version 20131207; > . change MASTER_SITES; > . use new LIB_DEPENDS syntax; > . incorporate USES=gmake; > . allow staging. The update has brought a dependency on dbus, which, IIUC, is only needed to support colord. May I suggest to make these dependencies optional, like in the patch below? Index: foomatic-filters/Makefile =================================================================== --- foomatic-filters/Makefile (revision 337750) +++ foomatic-filters/Makefile (working copy) @@ -11,8 +11,6 @@ LICENSE= GPLv2 -LIB_DEPENDS= libdbus-1.so:${PORTSDIR}/devel/dbus - USES= perl5 pkgconfig USE_AUTOTOOLS= autoheader USE_GHOSTSCRIPT=yes @@ -32,12 +30,13 @@ CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib -OPTIONS_DEFINE= A2PS CUPS_IMAGE MPAGE +OPTIONS_DEFINE= A2PS COLORD CUPS_IMAGE MPAGE OPTIONS_RADIO= ENSCRIPT OPTIONS_RADIO_ENSCRIPT= ENSCRIPT_A4 ENSCRIPT_LETTER ENSCRIPT_LETTERDJ OPTIONS_DEFAULT= CUPS_IMAGE A2PS ENSCRIPT_A4 MPAGE CUPS_IMAGE_DESC= Install cups image utilities A2PS_DESC= Install a2ps convertor +COLORD_DESC= Query colord (via dbus) ENSCRIPT_A4_DESC= Install enscript convertor (A4) ENSCRIPT_LETTER_DESC= Install enscript convertor (letter) ENSCRIPT_LETTERDJ_DESC= Install enscript convertor (letterdj) @@ -53,6 +52,14 @@ RUN_DEPENDS+= a2ps:${PORTSDIR}/print/a2ps .endif +.if ${PORT_OPTIONS:MCOLORD} +LIB_DEPENDS+= libdbus-1.so:${PORTSDIR}/devel/dbus +RUN_DEPENDS+= colormgr:${PORTSDIR}/graphics/colord +CONFIGURE_ARGS+= --enable-dbus +.else +CONFIGURE_ARGS+= --disable-dbus +.endif + .if ${PORT_OPTIONS:MENSCRIPT_A4} RUN_DEPENDS+= enscript:${PORTSDIR}/print/enscript-a4 .endif