From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 17:40:27 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F27A16A4D0 for ; Sun, 12 Sep 2004 17:40:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D40443D5A for ; Sun, 12 Sep 2004 17:40:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8CHeR9v009155 for ; Sun, 12 Sep 2004 17:40:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8CHeRMI009154; Sun, 12 Sep 2004 17:40:27 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 17:40:27 GMT Resent-Message-Id: <200409121740.i8CHeRMI009154@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 12E5716A4D7 for ; Sun, 12 Sep 2004 17:36:41 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id A449243D41 for ; Sun, 12 Sep 2004 17:36:39 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHabVF010920 for ; Sun, 12 Sep 2004 19:36:38 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHab2k010919 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:36:37 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409121736.i8CHab2k010919@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 19:36:37 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71669: [PATCH] cleanup of the usr.sbin/atm code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 17:40:27 -0000 >Number: 71669 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/atm code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 17:40:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386 usr.sbin/atm/scspd/scsp_hfsm.c,v 1.4 2002/10/10 00:32:55 alfred usr.sbin/atm/scspd/scsp_socket.c,v 1.4 2002/05/16 23:57:37 arr >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/atm/scspd/scsp_hfsm.c:132: warning: implicit declaration of function `abort' usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_UTP25' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_VIRTUAL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_DSL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_UTP25' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_VIRTUAL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_DSL' not handled in switch >How-To-Repeat: N/A >Fix: *** usr.sbin/atm/scspd/scsp_socket.c.ORIG Mon Jul 1 23:51:35 2002 --- usr.sbin/atm/scspd/scsp_socket.c Sun Sep 12 16:56:39 2004 *************** *** 316,321 **** --- 316,322 ---- traffic.backward.PCR_all_traffic = ATM_PCR_OC12C; break; case MEDIA_UNKNOWN: + default: break; } *************** *** 503,508 **** --- 504,510 ---- traffic.backward.PCR_all_traffic = ATM_PCR_OC12C; break; case MEDIA_UNKNOWN: + default: break; } *** usr.sbin/atm/scspd/scsp_hfsm.c.ORIG Sat Oct 12 03:59:55 2002 --- usr.sbin/atm/scspd/scsp_hfsm.c Sun Sep 12 16:57:38 2004 *************** *** 51,56 **** --- 51,57 ---- #include #include #include + #include #include #include "scsp_msg.h" >Release-Note: >Audit-Trail: >Unformatted: